LauncherSpec: Let it work on Windows #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
rvl
force-pushed
the
rvl/703/fix-launcher-spec-windows
branch
from
a17e5f3
to
cc13c5f
Compare
| @@ -92,10 +94,21 @@ spec = do | |||
| name `shouldBe` "foobar" | |||
|
|
|||
| -- | A command that will run for a short time then exit with the given status. | |||
There was a problem hiding this comment.
I think this comment is no longer correct. (The given status is no longer passed as a parameter.)
There was a problem hiding this comment.
OK thanks I have fixed it.
KtorZ
approved these changes
Nov 5, 2019
Although the integration tests for this are disabled.
rvl
force-pushed
the
rvl/703/fix-launcher-spec-windows
branch
from
cc13c5f
to
4f5c803
Compare
|
Rebased and fixed the OS detection, so now the tests pass. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 6, 2019
959: LauncherSpec: Let it work on Windows r=rvl a=rvl Relates to #703. # Overview - LauncherSpec used posix commands for testing. - This substitutes equivalent commands when running on windows. Co-authored-by: Rodney Lorrimar <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #703.
Overview