Turn on disabled 'forget tx' integration tests for Byron #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
commented
Nov 7, 2019
| "byron-wallets" xit fixtureByronWallet | ||
| postByronTxEp listByronTxEp deleteByronTxEp | ||
| it "TRANS_DELETE_01 -\ | ||
| \ Shelley: Can forget pending transaction" $ \ctx -> do |
There was a problem hiding this comment.
this test for Shelley is the same as before, I just derived it from the method since it is not reusable for Byron...
| expectResponseCode @IO HTTP.status204 rDel | ||
|
|
||
| it "TRANS_DELETE_02 -\ | ||
| \ Shelley: Cannot forget tx that is already in ledger" $ \ctx -> do |
There was a problem hiding this comment.
same here - the same as before for Shelley...
KtorZ
approved these changes
Nov 7, 2019
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 7, 2019
978: Turn on disabled 'forget tx' integration tests for Byron r=piotr-iohk a=piotr-iohk # Issue Number #836 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [ ] I have turned on disabled 'forget tx' integration tests for Byron (they were `pending` because of `fixtureByronWallet` was not working as expected before) # Comments - `pending` tests were assuming that it is possible to make transaction on Byron wallet, so I had to re-worked them a bit to forget transaction that was part of migration. Co-authored-by: Piotr Stachyra <[email protected]>
Build failed |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 7, 2019
978: Turn on disabled 'forget tx' integration tests for Byron r=piotr-iohk a=piotr-iohk # Issue Number #836 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [ ] I have turned on disabled 'forget tx' integration tests for Byron (they were `pending` because of `fixtureByronWallet` was not working as expected before) # Comments - `pending` tests were assuming that it is possible to make transaction on Byron wallet, so I had to re-worked them a bit to forget transaction that was part of migration. Co-authored-by: Piotr Stachyra <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#836
Overview
pendingbecause offixtureByronWalletwas not working as expected before)Comments
pendingtests were assuming that it is possible to make transaction on Byron wallet, so I had to re-worked them a bit to forget transaction that was part of migration.