Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jörmungandr v0.7.0-rc4 → v0.7.0-rc5 #983

Merged
merged 12 commits into from
Nov 8, 2019
Merged

Jörmungandr v0.7.0-rc4 → v0.7.0-rc5 #983

merged 12 commits into from
Nov 8, 2019

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented Nov 7, 2019 •
edited by KtorZ
Loading

Issue Number

Overview

  • jÖrmungandr 0.7.0 rc5
  • Regenerate certificates and genesis block used in integration tests.
  • Update Binary module to deserialize new block format.
  • Update External Tx tests: jcli interface has changed a bit.

Comments

@piotr-iohk piotr-iohk self-assigned this Nov 7, 2019
@piotr-iohk piotr-iohk added this to the Usability & Compatibility milestone Nov 7, 2019
@piotr-iohk
Copy link
Contributor Author

bors try

iohk-bors bot added a commit that referenced this pull request Nov 7, 2019
@iohk-bors
Try #983:
8efcbde
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 7, 2019

try

Build failed

@rvl
Copy link
Contributor

rvl commented Nov 8, 2019

I see this message from jormungandr in the test logs:

Parsing error on Block0
--
  | \|-> Structure invalid: Invalid config parameter tag
  |  

@rvl rvl changed the title jÖrmungandr 0.7.0 rc5 wip: Jörmungandr v0.7.0-rc4 → v0.7.0-rc5 Nov 8, 2019
@KtorZ KtorZ changed the title wip: Jörmungandr v0.7.0-rc4 → v0.7.0-rc5 Jörmungandr v0.7.0-rc4 → v0.7.0-rc5 Nov 8, 2019
@KtorZ
Copy link
Member

KtorZ commented Nov 8, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 8, 2019
@iohk-bors @rvl @KtorZ
Merge #983
84d7d81 
983: Jörmungandr v0.7.0-rc4 → v0.7.0-rc5 r=KtorZ a=piotr-iohk

# Issue Number


# Overview

- [x] jÖrmungandr 0.7.0 rc5
- [x] Regenerate certificates and genesis block used in integration tests.
- [x] Update `Binary` module to deserialize new block format.
- [x] Update External Tx tests: jcli interface has changed a bit.


# Comments


Co-authored-by: Piotr Stachyra <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
Co-authored-by: KtorZ <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 8, 2019

Build failed

@Anviking
Copy link
Member

Anviking commented Nov 8, 2019 •
edited
Loading 

src/Test/Integration/Framework/DSL.hs:505:23:
  2) API Specifications TRANS_DELETE_05 - Cannot forget external tx via CLI
       waited more than 60s for value to reach or exceed 11111

jcli rest v0 message logs -h http://localhost:56162/api
---
- fragment_id: f32c8bc7555b4222606b7697debafe3ec9f38e571aa15849c320b7f22e5f3eb4
  last_updated_at: "2019-11-08T11:34:34.005986+00:00"
  received_at: "2019-11-08T11:34:33.000444+00:00"
  received_from: Rest
  status:
    Rejected:
      reason: "Invalid UTxO: Transaction is not found"
- fragment_id: ad02725798e2a4e63985cb138ca789a761fbbfa0589ba435a0c973fc9179ef74
  last_updated_at: "2019-11-08T11:34:32.009754+00:00"
  received_at: "2019-11-08T11:34:31.489799+00:00"
  received_from: Rest
  status:
    InABlock:
      block: 34c1c5218c1b2b56c9cef4bb9abba1518a0e9a20f99d588c5a446fc487b4bfa8
      date: "5670271.2"

🤔

@piotr-iohk
Copy link
Contributor Author

I bet it's caused by ->
dff630d

@KtorZ
Copy link
Member

KtorZ commented Nov 8, 2019

I can't reproduce locally...

@Anviking
Copy link
Member

Anviking commented Nov 8, 2019 •
edited
Loading

Running multiple tests fails: stack test cardano-wallet-jormungandr:integration --ta '--match "/API Specifications/TRANS_DELETE"'
But when running just one of the failing tests, it passes: stack test cardano-wallet-jormungandr:integration --ta '--match "/API Specifications/TRANS_DELETE_05 - Cannot forget external tx via CLI/"'

In the jcli tx preparation we use the tx hash eee758853b87403722cbf62405a2af445f307fd02bd6a3311b6c0688d7a47963 as input, corresponding to the first fund in the genesis block. It seems like we cannot hard-code it anymore (since the tx is "spent"), but shouldn't that have failed before too?

not sure if I'm missing som utxo basic here

@KtorZ
Copy link
Member

KtorZ commented Nov 8, 2019 •
edited
Loading

since the tx is "spent"

Ah! Right!

but shouldn't that have failed before too

No, we use to get the id by looking up in the node's UTxO, but we can't do that anymore, the endpoint was removed.

@KtorZ
Copy link
Member

KtorZ commented Nov 8, 2019

Okay, I am on it.

@piotr-iohk piotr-iohk mentioned this pull request Nov 8, 2019
Merged
2 tasks
@KtorZ
Copy link
Member

KtorZ commented Nov 8, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 8, 2019
@iohk-bors @rvl @KtorZ
Merge #983
95c0e9a 
983: Jörmungandr v0.7.0-rc4 → v0.7.0-rc5 r=KtorZ a=piotr-iohk

# Issue Number


# Overview

- [x] jÖrmungandr 0.7.0 rc5
- [x] Regenerate certificates and genesis block used in integration tests.
- [x] Update `Binary` module to deserialize new block format.
- [x] Update External Tx tests: jcli interface has changed a bit.


# Comments


Co-authored-by: Piotr Stachyra <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
Co-authored-by: KtorZ <[email protected]>
@KtorZ
Copy link
Member

KtorZ commented Nov 8, 2019

@Anviking @piotr-iohk

  • Now use proper faucet addresses (prefixed with external) from the genesis.yaml for constructing external transactions. There's a limited number, 10 of them which is sufficient for all our scenarios.
  • Also moved the transaction building code outside of the DSL since it's jormungandr-specific, and moved it in the jormungandr-specific faucet code.

@KtorZ
Copy link
Member

KtorZ commented Nov 8, 2019

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 8, 2019

Canceled

iohk-bors bot added a commit that referenced this pull request Nov 8, 2019
@iohk-bors @rvl @KtorZ
Merge #983
a29b53a 
983: Jörmungandr v0.7.0-rc4 → v0.7.0-rc5 r=KtorZ a=piotr-iohk

# Issue Number


# Overview

- [x] jÖrmungandr 0.7.0 rc5
- [x] Regenerate certificates and genesis block used in integration tests.
- [x] Update `Binary` module to deserialize new block format.
- [x] Update External Tx tests: jcli interface has changed a bit.


# Comments


Co-authored-by: Piotr Stachyra <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
Co-authored-by: KtorZ <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 8, 2019

Build succeeded

@iohk-bors iohk-bors bot merged commit a917a09 into master Nov 8, 2019
@KtorZ KtorZ deleted the piotr/jorm-0.7.0-rc5 branch November 8, 2019 15:33
iohk-bors bot added a commit that referenced this pull request Nov 8, 2019
@iohk-bors
Merge #988
b84678e 
988: Jormungandr 0.7.0 RC6 r=KtorZ a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] Jormungandr 0.7.0 RC6 in `jormungandr.nix`


# Comments

After #983.

Co-authored-by: Piotr Stachyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

@Anviking Anviking Anviking approved these changes

Assignees

@piotr-iohk piotr-iohk

Labels
None yet
Projects
None yet
Milestone
Usability & Compatibility
Development

Successfully merging this pull request may close these issues.
4 participants
@piotr-iohk @rvl @KtorZ @Anviking