Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: update cypress ui testing for report detail (MET-1481) #1479

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Feature: update cypress ui testing for report detail (MET-1481) #1479

merged 3 commits into from
Aug 3, 2023

Conversation

Sotatek-TungPham
Copy link
Collaborator

@Sotatek-TungPham Sotatek-TungPham commented Jul 31, 2023 •
edited by jira bot
Loading

Description

Update cypress ui testing for pool detail

  • All the test cases was passed
  • The page seems okay with the test

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: MET-1481

Testing & Validation

  • This PR has been tested/validated in Chrome, Firefox, Safari and Brave browsers.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence / README.md file) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Chrome

After
Screenshot 2023-07-31 at 17 21 29

@Sotatek-TungPham Sotatek-TungPham added the hold Hold label Jul 31, 2023
@Sotatek-DavidNguyen4 Sotatek-DavidNguyen4 added cf-review CF Review needed and removed hold Hold labels Aug 2, 2023
jimcase and others added 2 commits August 3, 2023 11:45
@jimcase
Squashed commit of the following:
9fe7d0b 
commit 9bab226
Author: trung.hoang <[email protected]>
Date:   Thu Aug 3 10:56:42 2023 +0700

    fix: env default for testing failed

commit f2f6e90
Author: ngoc.tran3 <[email protected]>
Date:   Thu Aug 3 10:36:49 2023 +0700

    fix(tests): TokenTransaction.test.tsx

commit 3242dca
Author: trung.hoang <[email protected]>
Date:   Thu Aug 3 10:25:09 2023 +0700

    fix(tests): ReportDetailStakeyTabs.test.tsx

commit a439f5e
Merge: 0b53c5d 536b44e
Author: trung.hoang <[email protected]>
Date:   Thu Aug 3 10:11:51 2023 +0700

    Merge branch 'chore/fix-unit-jest-test' of github.com-fe-explorer-cardano:cardano-foundation/cf-explorer-frontend into bugfix/unit-test

commit 536b44e
Author: Truong Manh Nguyen (truong.nguyen4) <[email protected]>
Date:   Thu Aug 3 10:10:44 2023 +0700

    chore: fix unit jest test

commit 0b53c5d
Merge: 417949f b744b7f
Author: trung.hoang <[email protected]>
Date:   Thu Aug 3 10:08:25 2023 +0700

    Merge branch 'bugfix/unit-test-failed' of github.com-fe-explorer-cardano:cardano-foundation/cf-explorer-frontend into bugfix/unit-test

commit b744b7f
Author: ngoc.tran3 <[email protected]>
Date:   Thu Aug 3 10:05:28 2023 +0700

    fix(tests): ContractDetail.test.tsx

commit 417949f
Merge: 5b71a08 ef4b7e9
Author: trung.hoang <[email protected]>
Date:   Thu Aug 3 09:59:52 2023 +0700

    Merge branch 'bugfix/unit-test-failed' of github.com-fe-explorer-cardano:cardano-foundation/cf-explorer-frontend into bugfix/unit-test

commit 52c585e
Author: ngoc.tran3 <[email protected]>
Date:   Thu Aug 3 09:59:12 2023 +0700

    fix(tests): Home.test.tsx

commit 5b71a08
Author: trung.hoang <[email protected]>
Date:   Thu Aug 3 09:58:19 2023 +0700

    fix: update unit test

commit ef4b7e9
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:41:55 2023 +0700

    fix(tests): DetailViewContractHash.test.tsx

commit 782a4a0
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:38:29 2023 +0700

    fix(tests): Delegations.test.tsx

commit 8eda41f
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:37:00 2023 +0700

    fix(tests): ToastContainer.test.tsx

commit b884efd
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:33:26 2023 +0700

    fix(tests): TokenAutocomplete.test.tsx

commit c621f49
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:30:32 2023 +0700

    fix(tests): Statistic.test.tsx

commit 4149d91
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:14:01 2023 +0700

    fix(tests): TransactionChart.test.tsx

commit 914699e
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:06:07 2023 +0700

    fix(tests): TopDelegators.test.tsx

commit 4fc1358
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 17:04:10 2023 +0700

    fix(tests): DetailViewToken.test.tsx

commit 6e6c9b7
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 16:55:13 2023 +0700

    fix(tests): ContractDetailContent.test.tsx

commit bc14d3d
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 16:53:23 2023 +0700

    fix(tests): DelegationOverview.test.tsx

commit 8ea9a61
Author: ngoc.tran3 <[email protected]>
Date:   Wed Aug 2 16:50:58 2023 +0700

    fix(tests): Layout.test.tsx

commit 3d5a1be
Merge: cbffaa3 e1f5eea
Author: Sotatek-ThuyetNguyen <[email protected]>
Date:   Wed Aug 2 09:46:38 2023 +0700

    Merge pull request #1493 from cardano-foundation/bugfix/MET-615-fix-next-page-of-seach-tokens

    fix: MET-615 reset paging when search token

commit cbffaa3
Merge: f48960d a3fff4c
Author: Sotatek-ThuyetNguyen <[email protected]>
Date:   Wed Aug 2 09:43:50 2023 +0700

    Merge pull request #1465 from cardano-foundation/bugfix/MET-615-Stake-address-registrarion-display-text-tot-delegated-to-any-pool

    fix: Stake-address-registrarion-display-text-tot-delegated-to-any-poo…

commit f48960d
Merge: 2c45e7f 260937e
Author: Sotatek-ThuyetNguyen <[email protected]>
Date:   Wed Aug 2 09:43:40 2023 +0700

    Merge pull request #1457 from cardano-foundation/bugfix/MET-1394-report-detail-text-deregistration-wrong

    fix: report-detail-text-deregistration-wrong( MET-1394 )

commit e1f5eea
Author: trung.hoang <[email protected]>
Date:   Tue Aug 1 10:24:14 2023 +0700

    fix: MET-615 fix net page of seach token

commit 2c45e7f
Merge: b2bed6b 0079292
Author: Sotatek-ThuyetNguyen <[email protected]>
Date:   Tue Aug 1 01:04:39 2023 +0700

    Merge pull request #1474 from cardano-foundation/bugfix/MET-1128-update-reward-type-delegators

    fix: MET-1128 update reward type delegators

commit b2bed6b
Merge: 8024b8c 94507ea
Author: Sotatek-ThuyetNguyen <[email protected]>
Date:   Tue Aug 1 01:04:22 2023 +0700

    Merge pull request #1459 from cardano-foundation/bugfix/MET-1441-remove-field-ROS

    fix: MET-1441 remove field ROS

commit 8024b8c
Merge: fec23aa 100294e
Author: Sotatek-ThuyetNguyen <[email protected]>
Date:   Tue Aug 1 01:04:05 2023 +0700

    Merge pull request #1453 from cardano-foundation/bugfix/tabular-view-pool-name-tooltip

    fix: tabular view display pool name tooltip wrong position

commit fec23aa
Merge: d3ce601 66ba11e
Author: Sotatek-ThuyetNguyen <[email protected]>
Date:   Tue Aug 1 01:03:45 2023 +0700

    Merge pull request #1449 from cardano-foundation/bugfix/protocol-show-empty-when-initial-page

    fix: protocal show notfound when initial page

commit d3ce601
Merge: 8ec94d7 e113266
Author: Sotatek-ThuyetNguyen <[email protected]>
Date:   Tue Aug 1 01:02:02 2023 +0700

    Merge pull request #1431 from cardano-foundation/bugfix/MET-1452-finding1-view-only-tokens-in-dropdown-search

    fix: MET-1452 finding 1 view only tokens in dropdown search

commit 8ec94d7
Merge: 4852c02 7c3becf
Author: Sotatek-ThuyetNguyen <[email protected]>
Date:   Tue Aug 1 01:01:27 2023 +0700

    Merge pull request #1399 from cardano-foundation/bugfix/MET-1156-add-marking-special-multiple-delegation-transaction

    fix: MET-1156 add marking special multiple delegation trasaction

commit 4852c02
Author: Roberto C. Morano <[email protected]>
Date:   Mon Jul 31 13:53:11 2023 +0200

    chore(gha): trying to fix smoke tests

commit f48de11
Author: Roberto C. Morano <[email protected]>
Date:   Mon Jul 31 13:43:07 2023 +0200

    chore(gha): added python-requests depend

commit 2807cfb
Author: Roberto C. Morano <[email protected]>
Date:   Mon Jul 31 13:13:14 2023 +0200

    chore(gha): switch every job to self-hosted

commit 0079292
Author: trung.hoang <[email protected]>
Date:   Mon Jul 31 16:44:07 2023 +0700

    fix: MET-1128 update reward type delegators

commit a3fff4c
Author: huy.nguyen <[email protected]>
Date:   Mon Jul 31 14:51:51 2023 +0700

    fix: Stake-address-registrarion-display-text-tot-delegated-to-any-pool(MET-615)

commit 7c3becf
Merge: 4111def 7ee8bb5
Author: ngoc.tran3 <[email protected]>
Date:   Mon Jul 31 11:03:27 2023 +0700

    fix: MET-1156 add marking special multiple delegation trasaction fix conflict

commit 94507ea
Author: trung.hoang <[email protected]>
Date:   Mon Jul 31 10:38:51 2023 +0700

    fix: MET-1441 remove field ROS

commit 260937e
Author: huy.nguyen <[email protected]>
Date:   Mon Jul 31 10:05:16 2023 +0700

    fix: report-detail-text-deregistration-wrong( MET-1394 )

commit 100294e
Author: ngoc.tran3 <[email protected]>
Date:   Fri Jul 28 18:08:40 2023 +0700

    fix: tabular view display pool name tooltip wrong position

commit 66ba11e
Author: ngoc.tran3 <[email protected]>
Date:   Fri Jul 28 17:36:12 2023 +0700

    fix: protocal show notfound when initial page

commit e113266
Author: trung.hoang <[email protected]>
Date:   Fri Jul 28 15:39:21 2023 +0700

    fix: MET-1452 finding 1 view only tokens in dropdown search

commit 4111def
Author: ngoc.tran3 <[email protected]>
Date:   Thu Jul 27 17:35:14 2023 +0700

    fix: MET-1156 add marking special multiple delegation trasaction
@rcmorano @jimcase
chore(gha): reverting to github-managed runners
5e50679
@jimcase jimcase merged commit dbac95c into develop Aug 3, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Aug 7, 2023
Merged
@sato-thuyetnguyen sato-thuyetnguyen deleted the feature/MET-1481-cypress-ui-testing-for-report-detail branch August 10, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimcase jimcase jimcase approved these changes

@Sotatek-DavidNguyen4 Sotatek-DavidNguyen4 Awaiting requested review from Sotatek-DavidNguyen4

@fabianbormann fabianbormann Awaiting requested review from fabianbormann

Assignees

@fabianbormann fabianbormann

@jimcase jimcase

Labels
cf-review CF Review needed test-failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sotatek-TungPham @jimcase @fabianbormann @Sotatek-DavidNguyen4 @rcmorano