-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart Contracts: expand overview page #1080
Smart Contracts: expand overview page #1080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great content here. I still don't work with smart contracts so this has been a real pleasure to read. Only needed some touch up edits mainly for use of English possessive (-s
vs. -'s
) and I offset some italicised notes as styled admonitions.
(p.s. words spelled 2 different acceptable ways, like utxo's
and utxos
, I generally left alone unless spelled 2 different ways in the same sentence)
Will double check now in local build to be sure all still looks good. Looking forward to signing off on this as soon as you are happy taking it out of Draft review state.
Note @OlofBlomqvist GitHub is being slow to connect my edits in your branch to this PR. Here is the latest change (OlofBlomqvist@01c2ec4) which I'm still waiting more than 15 minutes to show up in the rendered document & in the diff. Hope my editing this way has been helpful for you (I'm done for now unless you put in more sections of text). Thanks again for the brilliant content 🤓 |
Much appreciated, thanks! :) |
My commit still not merged with this branch after 35 minutes; so perhaps best to wait for further review until GitHub problem is fixed (my own review was based on content in my local branch): https://www.githubstatus.com
|
should be OK to review now, along with the rest of GitHub...
|
Checklist
yarn build
after adding my changes without getting any errors.Updating documentation or Bugfix
The current overview page contains more than a few logical & technical errors, and it also does not seem to be written with developers as the intended target audience. At least for me, it was of little use when I got started with Cardano.
In this PR I try to make the overview more useful as a general introduction for developers getting started on Cardano, without going in to too much detail