Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NFTdot.io entry as per latest requirements #187

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

nftdot
Copy link
Contributor

@nftdot nftdot commented Jul 26, 2021

Added NFTdot.io entry as per latest requirements at the end of the list with the thumbnail file. Thanks.

Added entry for NFTdot.io at the end of the file as per lataest requirements.
Added NFTdot.io thumbnail
@netlify
Copy link

netlify bot commented Jul 26, 2021

✔️ Deploy Preview for elated-mestorf-f7e334 ready!

🔨 Explore the source changes: 347403f

🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-mestorf-f7e334/deploys/60fea8cb0511ac0009ecbf13

😎 Browse the preview: https://deploy-preview-187--elated-mestorf-f7e334.netlify.app

@tweakch
Copy link
Collaborator

tweakch commented Jul 26, 2021

Hi @nftdot,
I saw you closed your PR and opened a new one with the requested changes. there is a much simpler way.

In the future, If a reviewer asks you to change your PR, you can

  • checkout the branch where your PR is from git checkout staging
  • make the requested changes
  • maybe they asked you to add a file (i.e. a .png) git add <file>
  • commit the requested changes git commit -m "add image and append showcase"
  • git push

or in your browser:

  • open the PR in Github,
  • navigate to the files changed tab,
  • click ... on the file where the changes have been requested
  • edit it
  • Add a commit message
  • click Commit changes

Your changes will be reflected within your PR (i.e. #182).

@nftdot
Copy link
Contributor Author

nftdot commented Jul 26, 2021 via email

@nftdot
Copy link
Contributor Author

nftdot commented Jul 27, 2021

Ho much time does it ussualy takes to approve an entry into the list?

Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the contribution.

I'd recommend to also add the "token" tag. You can just push another commit to this branch as long as the pull request is open.

@katomm
Copy link
Member

katomm commented Jul 27, 2021

Ho much time does it usually takes to approve an entry into the list?

We haven't collected stats for it yet. You need 3 independent approvals.

@nftdot
Copy link
Contributor Author

nftdot commented Jul 28, 2021

Fair enough. So now we know at least that the submission looks good and there isn't anything for me to do but wait for you and other reviewers in your forum to validate it. I think I have seen on this commit already 2 people, so now I guess we need just another one to help us and validate it.

Thank you in advance for your support.

@nftdot
Copy link
Contributor Author

nftdot commented Jul 28, 2021

@tweakch would you so kind to approve my request so it gets finally approved? Thank you.

@nftdot
Copy link
Contributor Author

nftdot commented Jul 28, 2021

I see there are 3 approvals on this change, but not sure yet on the process as it is our first commit. how does it work to get this pushed live and see the NFTdot.io entry onto the page: https://developers.cardano.org/showcase/ ?

@katomm katomm merged commit 93810b7 into cardano-foundation:main Jul 28, 2021
@katomm
Copy link
Member

katomm commented Jul 28, 2021

Sorry, it is normal that this process takes some time. In the future, please make the PR always against staging, not against the main branch. Thank you.

Mercurial pushed a commit that referenced this pull request Jul 29, 2021
* Update showcases.js

Added entry for NFTdot.io at the end of the file as per lataest requirements.

* Add files via upload

Added NFTdot.io thumbnail
katomm added a commit that referenced this pull request Jul 30, 2021
* JES Art splash image

* JES-Art added

* Fix links in Rust lib (#191)

* Fix metadata link

* Remove broken link and add legacy key format

* builder-tools: adding cardano-metadata-oracle (#192)

* Added NFTdot.io entry as per latest requirements (#187)

* Update showcases.js

Added entry for NFTdot.io at the end of the file as per lataest requirements.

* Add files via upload

Added NFTdot.io thumbnail

* General Markdown Fixes on Mint Page (#196)

Co-authored-by: Sp33dy 
Co-authored-by: Marek Mahut 
Co-authored-by: NFT dot 
Co-authored-by: Kyle Johns
@katomm katomm added the showcase Indicates a PR/issue on showcase label Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
showcase Indicates a PR/issue on showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants