-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added NFTdot.io entry as per latest requirements #187
Conversation
Added entry for NFTdot.io at the end of the file as per lataest requirements.
Added NFTdot.io thumbnail
✔️ Deploy Preview for elated-mestorf-f7e334 ready! 🔨 Explore the source changes: 347403f 🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-mestorf-f7e334/deploys/60fea8cb0511ac0009ecbf13 😎 Browse the preview: https://deploy-preview-187--elated-mestorf-f7e334.netlify.app |
Hi @nftdot, In the future, If a reviewer asks you to change your PR, you can
or in your browser:
Your changes will be reflected within your PR (i.e. #182). |
Hi,
I was asked by a reviewer as you can probably see to place my NFTdot.io
entry at the end of the list. I wasn't aware of this rule, but had nothing
against it so I did the change and updated the pull, but since I haven't
seen a new review of the corrected pull in a week now or maybe my resubmit
was not done correctly as per your specs, so I closed it and resubmitted it
from scratch.
Hope this time it is reviewed and approved as it is compliant with all
rules I know so far.
Thank you.
…On Mon, 26 Jul 2021 at 17:01, Alexander Klee ***@***.***> wrote:
Hi @nftdot <https://github.com/nftdot>,
I saw you closed your PR and opened a new one with the requested changes.
there is a much simpler way.
If a reviewer asks you to change your PR, you can
- checkout the branch where your PR is from git checkout staging
- make the requested changes
- maybe they asked you to add a file (i.e. a .png) `git add
- commit the requested changes git commit -m "add image and append
showcase"
- git push
Your changes will be reflected within your PR (i.e. #182
<#182>).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#187 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUUAYJUSWGRVQC66B33DECDTZVTE3ANCNFSM5A77TDOA>
.
|
Ho much time does it ussualy takes to approve an entry into the list? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for the contribution.
I'd recommend to also add the "token" tag. You can just push another commit to this branch as long as the pull request is open.
We haven't collected stats for it yet. You need 3 independent approvals. |
Fair enough. So now we know at least that the submission looks good and there isn't anything for me to do but wait for you and other reviewers in your forum to validate it. I think I have seen on this commit already 2 people, so now I guess we need just another one to help us and validate it. Thank you in advance for your support. |
@tweakch would you so kind to approve my request so it gets finally approved? Thank you. |
I see there are 3 approvals on this change, but not sure yet on the process as it is our first commit. how does it work to get this pushed live and see the NFTdot.io entry onto the page: https://developers.cardano.org/showcase/ ? |
Sorry, it is normal that this process takes some time. In the future, please make the PR always against staging, not against the main branch. Thank you. |
* Update showcases.js Added entry for NFTdot.io at the end of the file as per lataest requirements. * Add files via upload Added NFTdot.io thumbnail
* JES Art splash image * JES-Art added * Fix links in Rust lib (#191) * Fix metadata link * Remove broken link and add legacy key format * builder-tools: adding cardano-metadata-oracle (#192) * Added NFTdot.io entry as per latest requirements (#187) * Update showcases.js Added entry for NFTdot.io at the end of the file as per lataest requirements. * Add files via upload Added NFTdot.io thumbnail * General Markdown Fixes on Mint Page (#196) Co-authored-by: Sp33dy Co-authored-by: Marek Mahut Co-authored-by: NFT dot Co-authored-by: Kyle Johns
Added NFTdot.io entry as per latest requirements at the end of the list with the thumbnail file. Thanks.