Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Guild Ops Suite as Operator tool #228

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Add Guild Ops Suite as Operator tool #228

merged 1 commit into from
Aug 10, 2021

Conversation

rdlrt
Copy link
Collaborator

@rdlrt rdlrt commented Aug 10, 2021 •
edited
Loading

Operator Tool addition

Description of the change

  • Add Guild Operators Suite to getting-started page.
  • Rename cntools reference to guild-ops-suite as superset.
  • Fix logical error (AND to NAND, and instanceOf -> typeOf) in checkOperatorTool function in builder-tools.js

@rdlrt rdlrt requested a review from katomm August 10, 2021 03:18
@rdlrt rdlrt marked this pull request as ready for review August 10, 2021 06:21
gufmar
gufmar approved these changes Aug 10, 2021
View reviewed changes
Copy link
Collaborator

@gufmar gufmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

katomm
katomm approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you for the contribution. Small note: I think the notebox with the "disclaimer" has a tab in which results into a code box within the note box.

@rdlrt
Copy link
Collaborator Author

rdlrt commented Aug 10, 2021 •
edited
Loading

Very nice, thank you for the contribution. Small note: I think the notebox with the "disclaimer" has a tab in which results into a code box within the note box.

Ah - I think I fixed it with the next [squashed] commit before marking it ready 👍🏻

Scitz0
Scitz0 approved these changes Aug 10, 2021
View reviewed changes
Copy link
Collaborator

@Scitz0 Scitz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@rdlrt rdlrt merged commit d196670 into staging Aug 10, 2021
@rdlrt rdlrt deleted the guild-ops-suite branch August 10, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katomm katomm katomm approved these changes

@Scitz0 Scitz0 Scitz0 approved these changes

@gufmar gufmar gufmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rdlrt @gufmar @Scitz0 @katomm