Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set placeholder fee for fee-calculating transaction #283

Merged
merged 3 commits into from
Sep 12, 2021

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Sep 9, 2021

@katomm has already suggested a PR be opened for this.

This is a response to a documentation problem reported here, saying that the fee itself must be known before the transaction that calculates the fee. I believe this results from people running through the token creation exercises without yet having the basic transaction building experience (e.g. the process described here for stake pool operators).

The forum comment implies setting fee="0" occurs so early in the flow of the affected page-- where it's included with general variables for the testing environment-- that it's easily missed. I've moved it forward into the "Build the raw transaction" section so that the fee is initialised to zero immediately before that test transaction, along with an explanation of why the fee has to be specified twice (first an ignored value, then the calculated value).

@rphair rphair changed the title clarify set fee=0 before building fee calculating transaction set placeholder fee for fee calculating transaction Sep 9, 2021
@rphair rphair changed the title set placeholder fee for fee calculating transaction set placeholder fee for fee-calculating transaction Sep 9, 2021
@rphair
Copy link
Collaborator Author

rphair commented Sep 9, 2021

I swear Github has promised in more than one place that it factors out "dos" vs. "unix" line terminations so they're not supposed to make a difference in the diffs. Will try to submit again with fileformat closer to the original (which was effectively "dos"). 😓

Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution, also thanks to @AndrewWestberg

@katomm katomm merged commit 9084abf into cardano-foundation:staging Sep 12, 2021
@den-is
Copy link

den-is commented Sep 21, 2021

Hey guys, so is that related to assets minting transactions fees or is useful for any ADA transaction too, as a good new "best practice"? (for example p2p ADA transactions, rewards withdrawal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants