Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cardano-wallet-js #313

Merged
merged 8 commits into from
Oct 6, 2021
Merged

Conversation

leobel
Copy link
Contributor

@leobel leobel commented Sep 22, 2021


Showcase addition


docs/get-started/cardano-wallet-js.md Outdated Show resolved Hide resolved
docs/get-started/cardano-wallet-js.md Outdated Show resolved Hide resolved
@leobel leobel requested a review from rdlrt September 23, 2021 12:30
@katomm katomm added the showcase Indicates a PR/issue on showcase label Sep 25, 2021
@leobel
Copy link
Contributor Author

leobel commented Oct 4, 2021

Hi, I'd like to know if we as the PR creators needs to do something else or just wait for more feedbacks. The PR has been quiet for a long time :(

@katomm
Copy link
Member

katomm commented Oct 5, 2021

Hi, I'd like to know if we as the PR creators needs to do something else or just wait for more feedbacks. The PR has been quiet for a long time :(

No, all is well from your side, thanks.

@katomm katomm added builder tool Indicates a PR/issue on a builder tool and removed showcase Indicates a PR/issue on showcase labels Oct 6, 2021
Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @leobel

@katomm katomm merged commit 6e8bdda into cardano-foundation:staging Oct 6, 2021
katomm added a commit that referenced this pull request Oct 8, 2021
…347)

* Add cardano-wallet-js (#313)

* cardano-wallet-js

* fix description

* fix comments

* include tags and fix typo

* adapt get started page to styling guide

Co-authored-by: javiertc

* update instructions for cardano-wallet 2021.09.09 (#319)

* Minor correction (#344)

* Update node checkout references, replace home directory references (#341)

* Change witness count to 2 for minting transactions (#322)

You sign with payment key and policy key, so I guess the witness count should be 2 for those transactions instead of 1?

* Change witness count to 2 for minting transactions (#323)

You sign with payment key and policy key, so I guess the witness count should be 2 for those transactions instead of 1?

* Fixes documentation Stake Pool Course Handbook (#342)

Fixes documentation Stake Pool Course Handbook "Register stake pool keys" chapter. Instead of keyDeposit it should be stakeAddressDeposit.

* Fix captcha issue raised in #339 (#346)

Co-authored-by: Leobel Izquierdo 
Co-authored-by: Dan Loewenherz
Co-authored-by: Ganesh 
Co-authored-by: Priyank 
Co-authored-by: brouwerQ 
Co-authored-by: Jurijs I
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder tool Indicates a PR/issue on a builder tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants