Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed 404 to min ada value calculations #400

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

nirhy
Copy link
Contributor

@nirhy nirhy commented Oct 31, 2021

Updating documentation

Description of the change

clicking on the href for " Cardano ledger docs for further reading" led to 404
Updated the link to be https://cardano-ledger.readthedocs.io/en/latest/explanations/min-utxo-alonzo.html#example-min-ada-value-calculations-and-current-constants

Copy link
Collaborator

@rdlrt rdlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @nirhy

@katomm katomm merged commit 8db90a2 into cardano-foundation:staging Nov 3, 2021
@Scitz0
Copy link
Collaborator

Scitz0 commented Nov 3, 2021

Should we link to both mary and alonzo docs for this, or is alonzo enough?
Like for example utxoEntrySizeWithoutVal in alonzo doc isn't really explained, the connection to coinSize constant updated in alonzo fork from 0 to 2. This changes the utxoEntrySizeWithoutVal value from 27 to 29. And 1000000 lovelace for Ada only utxo isn't correct. Its utxoEntrySize (txout) = utxoEntrySizeWithoutVal + size (v) => 999978 = 29 * 34482. But I guess this is a flaw in alonzo doc and that its better to update this.

Mary can be found here:
https://cardano-ledger.readthedocs.io/en/latest/explanations/min-utxo-mary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants