Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploring cardano-wallet - Some simplifications #467

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

morucci
Copy link
Contributor

@morucci morucci commented Jan 6, 2022

  • Pipe "cardano-wallet recovery-phrase generate" into jq to get JSON array
  • Do not recall POST payload in explanation
  • Keep same wallet.id accross commands/examples
  • Keep same address as in explanation
  • Remove "--request GET" for curl command as this is the default

@morucci morucci marked this pull request as draft January 6, 2022 23:21
- Pipe "cardano-wallet recovery-phrase generate" into jq to get JSON array
- Do not recall POST payload in explanation
- Keep same wallet.id accros commands/examples
- Keep same address as in explanation
- Remove "--request GET" for curl command as this is the default
@morucci morucci changed the title Pipe "cardano-wallet recovery-phrase generate" into jq to get JSON array Exploring cardano-wallet - Some simplifications Jan 6, 2022
@morucci morucci marked this pull request as ready for review January 6, 2022 23:43
Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@katomm katomm merged commit 331d515 into cardano-foundation:staging Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants