Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link to Testnet Faucet #634

Merged
merged 2 commits into from
May 31, 2022
Merged

Fix broken link to Testnet Faucet #634

merged 2 commits into from
May 31, 2022

Conversation

fill-the-fill
Copy link
Collaborator

@fill-the-fill fill-the-fill commented May 23, 2022 •
edited
Loading

Bugfix

Fix broken link mentioned in #628

@fill-the-fill fill-the-fill mentioned this pull request May 23, 2022
Closed
katomm
katomm reviewed May 23, 2022
View reviewed changes
Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt this fixes the problem in #628 as .md is optional.

@rdlrt
Copy link
Collaborator

rdlrt commented May 23, 2022

I am unclear what are we fixing, the mentioned page here seems to have correct hyperlink which takes you to faucet page

@fill-the-fill
Copy link
Collaborator Author

fill-the-fill commented May 24, 2022 •
edited
Loading

I am unclear what are we fixing, the mentioned page here seems to have correct hyperlink which takes you to faucet page

Correct me if I'm wrong, but the current link is broken

@katomm
Copy link
Member

katomm commented May 24, 2022 •
edited
Loading

I believe it is again this issue #312 it is a problem when using relative links, it seems the only good way to rule this out is to write /docs/something

cc: @rdlrt @fill-the-fill @BharatAtEMURGOIO

@rdlrt
Copy link
Collaborator

rdlrt commented May 24, 2022

I believe it is again this issue #312 it is a problem when using relative links, it seems the only good way to rule this out is to write /docs/something

cc: @rdlrt @fill-the-fill @BharatAtEMURGOIO

Ah gotcha, explains why I wasn't able to replicate when checking hyperlinks 👍

@katomm
Copy link
Member

katomm commented May 30, 2022

Any update on this?

@fill-the-fill fill-the-fill added the bug Something isn't working label May 30, 2022
@fill-the-fill
Copy link
Collaborator Author

Any update on this?

Seems like adding /docs does solve the issue

mallapurbharat
mallapurbharat approved these changes May 31, 2022
View reviewed changes
Copy link

@mallapurbharat mallapurbharat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this seems to work fine now. Thanks!

@katomm
Copy link
Member

katomm commented May 31, 2022

Yes, this seems to work fine now. Thanks!

Great, see you at Emurgo Academy!

@katomm katomm merged commit 31ee2ed into cardano-foundation:staging May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katomm katomm katomm left review comments

@mallapurbharat mallapurbharat mallapurbharat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fill-the-fill @rdlrt @katomm @mallapurbharat @fickevics-makor