-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plutus: 1.30 -> 1.34.1 #1544
plutus: 1.30 -> 1.34.1 #1544
Conversation
53b33e9
to
8d8d3a3
Compare
Currently waiting for IntersectMBO/ouroboros-consensus#1207 to progress on 1.32 |
4b22075
to
73c1aa6
Compare
e1f2dc3
to
31f0f44
Compare
hydra-plutus/scripts/mDeposit.plutus
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would want to keep this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem to be in the tests for this branch. I think the script got merged in the refactor but not the logic.
@@ -41,3 +41,6 @@ benchmarks: True | |||
|
|||
-- Always show detailed output for tests | |||
test-show-details: direct | |||
|
|||
allow-newer: base | |||
allow-newer: plutus-ledger-api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which packages do need these constraints? There is a nice syntax here to provide more context. I think it goes like: allow-newer: somepkg:base
to say that somepkg
needs to have its upper bounds removed for base
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't this is is noise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is noise from ghc 9.10. Not relevant to this PR.
61aae8f
to
662e3b9
Compare
662e3b9
to
aefb8f6
Compare
aefb8f6
to
53960e9
Compare
53960e9
to
87f63df
Compare
I don't see the rationale for this PR (in isolation). Shall we just continue with #1680 instead? |
Yes. |
No description provided.