Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce (on-chain) that Hydra transitions are authenticated by participants #292

Merged
merged 18 commits into from
Mar 28, 2022
Merged

Enforce (on-chain) that Hydra transitions are authenticated by participants #292

merged 18 commits into from
Mar 28, 2022

Commits on Mar 28, 2022

  1. Inject signer mutation for CollectCom #284

    @abailly-iohk
    abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    a117def View commit details
    Browse the repository at this point in the history

  2. Sketch validation of CollectCom signers #284

    @abailly-iohk
    abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    cc1f759 View commit details
    Browse the repository at this point in the history

  3. Extract tokens from outputs and implement signatory verification.

    @KtorZ @abailly-iohk
    KtorZ authored and abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    239f0bc View commit details
    Browse the repository at this point in the history

  4. Try to generate key for signing CollectCom tx #284

    @abailly-iohk
    abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    0b1e47c View commit details
    Browse the repository at this point in the history

  5. Extract 'signWith' from TinyWallet and use it to authenticate Collect… 

    …com with party's credentials.
    @KtorZ @abailly-iohk
    KtorZ authored and abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    a5cc71d View commit details
    Browse the repository at this point in the history

  6. Add signer's vk to the explicit required signers list when signing.

    @KtorZ @abailly-iohk
    KtorZ authored and abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    99e1572 View commit details
    Browse the repository at this point in the history

  7. Add 'mutate required signer' to Abort. Mutation tests fail.

    @KtorZ @abailly-iohk
    KtorZ authored and abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    d86f5c5 View commit details
    Browse the repository at this point in the history

  8. Refactor head contract to re-use logic for checking signatories on-ch… 

    …ain.
    @KtorZ @abailly-iohk
    KtorZ authored and abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    bcc3f46 View commit details
    Browse the repository at this point in the history

  9. Add signers to the health abort transaction 

      Moved some logic around to make it possible.
    @KtorZ @abailly-iohk
    KtorZ authored and abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    b797019 View commit details
    Browse the repository at this point in the history

  10. Add mutation mutation to close tx about required signers.

    @KtorZ @abailly-iohk
    KtorZ authored and abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    598727a View commit details
    Browse the repository at this point in the history

  11. Implement signature verification on-chain for close transition.

    @KtorZ @abailly-iohk
    KtorZ authored and abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    8954ed5 View commit details
    Browse the repository at this point in the history

  12. Repair healthy close tx, and correctly gather signatures on-chain.

    @KtorZ @abailly-iohk
    KtorZ authored and abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    e6e2cef View commit details
    Browse the repository at this point in the history

  13. Fix finding Head currency symbol. 

      The initial version of the function was fine for pre-CollectCom transitions, but after the collect-com has happened, PTs are all aggregated under one policy and thus, there may be many assets locked by the head script.
    @KtorZ @abailly-iohk
    KtorZ authored and abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    20c3f35 View commit details
    Browse the repository at this point in the history

  14. Provide required signers when constructing Hydra on-chain transactions. 

      The rationale for doing this is double:

  (a) So far, we've been deferring signing up to inside the wallet and,
  requiring signature to happen on the transaction templates from
  Direct.Tx breaks a bit this abstraction. Moreso, we initially went
  that way because we thought that signing a transaction would result in
  the signatories being available on-chain in the Plutus context. Turns
  out that only explicitly specified signatories (in requiredSigners)
  end up in the Plutus context after all.

  (b) The 'State' abstraction we use internally is already tailored to
  one party and hold its 'ownVerificationKey'. So the Cardano signer key
  is already readily available and it is therefore much easier to
  provide it along the way. As a nice benefits, it makes it also clear
  from the signature of the low-level Direct.Tx functions that they now
  require to be explictly signed by a party.
    @KtorZ @abailly-iohk
    KtorZ authored and abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    4663032 View commit details
    Browse the repository at this point in the history

  15. Actually sign transaction AFTER modifying its body content 

      😬 ... now that're changing the 'requiredSigners', we need to make sure to sign the modified body, otherwise, we produce an invalid witness.
    @KtorZ @abailly-iohk
    KtorZ authored and abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    45da91e View commit details
    Browse the repository at this point in the history

  16. Revert adding required signers during 'signWith' 

      This is in fact no longer needed and had become error-prone. Now that the Direct.Tx primitives take care of adding the required signer, there's no need to fiddle with the tx body during signing anymore.
    @KtorZ @abailly-iohk
    KtorZ authored and abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    73c22e5 View commit details
    Browse the repository at this point in the history

  17. Leave note about failing (albeit wrong) integration test.

    @KtorZ @abailly-iohk
    KtorZ authored and abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    663249a View commit details
    Browse the repository at this point in the history

  18. Simplify Cardano cluster integration test #284 

    * Rename file to match what we are testing, eg. CardanoCluster and not
LocalCluster
* remove failing assertion that's not relevant anymore: This used to
test we could construct basic Hydra transactions "by hand" but it's
getting more complicated and pretty much useless as it's thoroughly
tested elsewhere
    @abailly-iohk
    abailly-iohk committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    afea828 View commit details
    Browse the repository at this point in the history