-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard against non-expected parties during init observation. #295
Commits on Apr 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f13d00b - Browse repository at this point
Copy the full SHA f13d00bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d19f707 - Browse repository at this point
Copy the full SHA d19f707View commit details -
Configuration menu - View commit details
-
Copy full SHA for 265767f - Browse repository at this point
Copy the full SHA 265767fView commit details -
Revert "Verify PTs match their respective pubkey hashes in head param…
…eters." & Revert "Add pub key hashes to list of parties in on-chain head parameters.". After discussing the next steps, we realized that passing the pub key hashes on-chain and checking the PTs does not actually provide any extra security guarantees and only makes the on-chain code more complicated. In the end, this is something we can only truly handle off-chain, durign the observation of an init transaction. It is the observer who knows the configuration it is expecting, and that can decide whether some observation is valid or not. On-chain, there isn't much we can do since, anyone crafting the init transaction may also change the redeemer, parameters or anything really. The participants of a head are BY DEFINITION the keys identified by the PT. Now, those participants may or may not reflect a known configuration of a node, but this is decided off-chain exclusively.
Configuration menu - View commit details
-
Copy full SHA for 1fa86d6 - Browse repository at this point
Copy the full SHA 1fa86d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7a5b9a - Browse repository at this point
Copy the full SHA f7a5b9aView commit details -
Define new mutation properties for testing off-chain code observation.
Use it for catching errors on an illed-formed init tx.
Configuration menu - View commit details
-
Copy full SHA for f65726e - Browse repository at this point
Copy the full SHA f65726eView commit details -
Fix output selection for init mutation: make tests fail for the right…
… reason. Whoopsie...
Configuration menu - View commit details
-
Copy full SHA for f95de75 - Browse repository at this point
Copy the full SHA f95de75View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4bc8ad - Browse repository at this point
Copy the full SHA a4bc8adView commit details -
Tweak observe-init mutation to mutate minted values instead of outputs.
Indeed... mutating outputs isn't caught by our guard because we only check minted values. Which is this however sufficient? (a) The ledger rules ensure that any minted value is actually properly distributed in outputs (transaction ins and outs must balance each other) (b) Our on-chain validator does ensure that the right number of assets are minted, in the right quantity, and that assets are distributed across the right number of outputs.
Configuration menu - View commit details
-
Copy full SHA for 7df5d2c - Browse repository at this point
Copy the full SHA 7df5d2cView commit details
Commits on Apr 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7814721 - Browse repository at this point
Copy the full SHA 7814721View commit details