Use cardano-node as a dependency and introduce CardanoNodeSpec #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-iohk
approved these changes
Apr 30, 2022
| nix-shell --arg withoutDevTools true --run 'cabal update' | ||
| nix-shell --arg withoutDevTools true --run 'cabal build ${{ matrix.package }}' | ||
| nix-shell --pure --arg withoutDevTools true --run 'cabal update' | ||
| nix-shell --pure --arg withoutDevTools true --run 'cabal build ${{ matrix.package }}' |
There was a problem hiding this comment.
What's the meaning of pure here?
There was a problem hiding this comment.
It does not use anything from the host environment. I think hai added it to not use git from mac or so..at least he added git, which was seemingly the only thing used from our hosts.
| withBFTNode tr cfgA $ \nodeA -> do | ||
| withBFTNode tr cfgB $ \nodeB -> do | ||
| withBFTNode tr cfgC $ \nodeC -> do | ||
| withBFTNode (nodeTracer cfgA) cfgA $ \nodeA -> do |
There was a problem hiding this comment.
Suggestion: only pass cfgA and retrieve tracer from it inside withBFTNode?
There was a problem hiding this comment.
Hmm, ok, it does not work the way I thought it worked :) Maybe this is more confusing than the previous version 🤔
Add cardano-node / cardano-cli via nix to shell.nix and add installation instructions to non-nix based setup. Also using pure nix-shells in CI
This also asserts the "right" cardano-version is available as we want to avoid false-positives in our integration tests -> see note in code.
abailly-iohk
force-pushed
the
refine-exe-deps
branch
from
a318cdb
to
47f86e2
Compare
|
@ch1bo I forced push an update to latest master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows-up and will close #178 as it adds the discussed check for
cardano-nodeversion present to avoid false-positives in case integration tests fail.While at it, I also introduced a
CardanoNodeSpecand movedwithBFTNodetohydra-clustersCardanoNodemodule + some minor moving of test code.