Account for contestation period in validators #351

KtorZ · 2022-05-12T14:04:26Z

github-actions · 2022-05-13T10:36:41Z

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at	2022-05-19 07:44:40.961358942 UTC
Max. memory units	14000000.00
Max. CPU units	10000000000.00
Max. tx size (kB)	16384

Cost of Init Transaction

Parties	Tx size	% max Mem	% max CPU
1	4736	30.43	17.83
2	4936	15.61	8.55
3	5137	16.80	9.07
5	5536	27.10	14.93
10	6537	29.57	15.40
30	10539	70.39	36.10
41	12739	87.21	44.06

Cost of Commit Transaction

Currently only one UTxO per commit allowed (this is about to change soon)

UTxO	Tx size	% max Mem	% max CPU
1	5862	17.98	8.81

Cost of CollectCom Transaction

Parties	Tx size	% max Mem	% max CPU
1	13740	23.34	12.73
2	14052	40.62	22.30
3	14543	63.11	35.03
4	14923	87.54	48.99

Cost of Close Transaction

Parties	Tx size	% max Mem	% max CPU
1	9119	9.46	5.02
2	9445	12.25	6.51
3	9628	13.37	7.12
5	9990	15.49	8.24
10	10987	22.37	11.96
30	14917	55.99	30.04
37	16248	68.61	36.86

Cost of Abort Transaction

Parties	Tx size	% max Mem	% max CPU

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

UTxO	Tx size	% max Mem	% max CPU
1	12987	8.61	4.98
2	13149	12.35	7.17
3	13183	14.94	8.63
5	13186	17.09	9.89
10	13421	25.38	14.61
50	14767	85.15	49.03
61	15068	99.28	57.13

github-actions · 2022-05-13T14:21:11Z

Unit Test Results

    5 files ±0   84 suites ±0 6m 48s ⏱️ -5s
222 tests ±0 220 ✔️ ±0 2 💤 ±0 0 ❌ ±0

Results for commit 312ac0f. ± Comparison against base commit 9bc8a8c.

♻️ This comment has been updated with latest results.

ch1bo · 2022-05-19T06:59:06Z

hydra-node/src/Hydra/Chain/Direct.hs

@@ -546,14 +604,21 @@ finalizeTx TinyWallet{sign, getUTxO, coverFee} headState partialTx = do
    Right validatedTx -> do
      pure $ sign validatedTx

+-- | Hardcoded grace time for close transaction to be valid.
+-- TODO: replace/remove with deadline contestation


I guess this TODO is moot now as we moved to a deadline already?

ch1bo · 2022-05-19T07:01:09Z

hydra-node/src/Hydra/Chain/Direct/State.hs

+getContestationDeadline :: OnChainHeadState 'StClosed -> POSIXTime
+getContestationDeadline
+  OnChainHeadState{stateMachine = Closed{closedThreadOutput = ClosedThreadOutput{closedContestationDeadline}}} =
+    closedContestationDeadline


This is slightly side-stepping the "non-introspectability" of the OnChainHeadState, but it's fine given the direction this is going.

ch1bo · 2022-05-19T07:02:56Z

hydra-node/src/Hydra/Chain/Direct/Tx.hs

+  , initialContestationPeriod :: OnChain.ContestationPeriod
+  , initialParties :: [OnChain.Party]
+  }
+  deriving (Eq, Show)


I like the direction in which this is going. As I said it yesterday, this is very similar to the InitObservation and I'm quite keen to unify them :)

ch1bo · 2022-05-19T07:04:21Z

hydra-node/src/Hydra/Chain/Direct/Tx.hs

        }
  utxoHash = toBuiltin $ hashTxOuts $ toList utxo

 fanoutTx ::
  -- | Snapshotted UTxO to fanout on layer 1
  UTxO ->
  -- | Everything needed to spend the Head state-machine output.
-  (TxIn, TxOut CtxUTxO, ScriptData) ->
+  UTxOWithScript ->


Could be a ClosedThreadOutput

ch1bo · 2022-05-19T07:06:49Z

hydra-node/test/Hydra/Chain/Direct/Contract/Close.hs

+        , utxoHash
+        , parties
+        , contestationDeadline =
+            -- FIXME: we don't have useful functions for manipulating time on-chain seemingly


What exactly is it to fix here? Sounds more like a complaint but slotNoToPOSIXTime works in this case?

ch1bo · 2022-05-19T07:08:09Z

hydra-node/test/Hydra/Chain/Direct/Contract/Contest.hs

              }
+      , SomeMutation MutateValidityPastDeadline . ChangeValidityInterval <$> do
+          lb <- arbitrary
+          ub <- TxValidityUpperBound <$> arbitrary `suchThat` slotOverContestationDeadline


Also here.. you're on a naming roll!

ch1bo · 2022-05-19T07:08:53Z

hydra-node/test/Hydra/Chain/DirectSpec.hs

@@ -35,7 +35,7 @@ import Test.QuickCheck (generate)
 spec :: Spec
 spec = do
  it "can init and abort a head given nothing has been committed" $
-    failAfter 10 $
+    failAfter 20 $


Did this become slower?

ch1bo · 2022-05-19T07:11:23Z

hydra-plutus/src/Hydra/Contract/Head.hs

+      let expectedOutputDatum =
+            Closed
+              { parties
+              , snapshotNumber = 0
+              , utxoHash = initialUtxoHash
+              , contestationDeadline = makeContestationDeadline cperiod ctx
+              }
+       in checkHeadOutputDatum ctx expectedOutputDatum


Introducing a variable for this feels a bit too verbose?

Suggested change

let expectedOutputDatum =

Closed

{ parties

, snapshotNumber = 0

, utxoHash = initialUtxoHash

, contestationDeadline = makeContestationDeadline cperiod ctx

}

in checkHeadOutputDatum ctx expectedOutputDatum

checkHeadOutputDatum ctx $

Closed

{ parties

, snapshotNumber = 0

, utxoHash = initialUtxoHash

, contestationDeadline = makeContestationDeadline cperiod ctx

}

ch1bo · 2022-05-19T07:11:45Z

hydra-plutus/src/Hydra/Contract/Head.hs

    | otherwise = traceError "negative snapshot number"
 {-# INLINEABLE checkClose #-}

+-- | Checks that the datum


that the datum.. ?

ch1bo · 2022-05-19T07:16:54Z

hydra-plutus/src/Hydra/Data/ContestationPeriod.hs

+  millisToPico = (* millisInPico)
+
+millisInPico :: Integer
+millisInPico = 10 ^ (9 :: Integer)


Name wrong way around? isn't it 10^9 pico seconds in a millisecond?

Also enhance cardano-api with pinned era types for lower and upper bound

…idityInterval

Currently set to arbitrary value as it's not really tested

We should probably drop this test anyway

…d State

One mutation for close is still failing, on purpose

KtorZ requested review from ch1bo and a user May 12, 2022 14:04

KtorZ force-pushed the ensemble/192/contestation-period branch from cc0ed45 to 3f97816 Compare May 12, 2022 14:19

ghost marked this pull request as ready for review May 18, 2022 10:28

ch1bo approved these changes May 19, 2022

View reviewed changes

abailly and others added 23 commits May 19, 2022 09:28

Introduce mutation for validity interval

f9d1fc9

Also enhance cardano-api with pinned era types for lower and upper bound

Define conversion function from cardano-api to cardano-ledger for Val…

0fa46cd

…idityInterval

Implement 'ChangeValidityInterval' mutation.

f30985b

Correctly generate mutated validity interval

f27f199

Ensure upper-bound validity of close tx is recorded in state on-chain.

87d6f1a

Set closedAt field everywhere it's used

dfe89f6

Currently set to arbitrary value as it's not really tested

Remove era witness in CardanoClient.

53a351b

Add a setValidityUpperBound to Builder

fcea94b

Extend closeTx to take slotNo and posixTime

e9536ef

Make healthy close tx healthy, using hard-coded parameters for now.

714d1ac

[wip] Start propagating slot no in Direct component

4f96672

Query the current point in time on every post chain tx

db2c3df

retain the closed at boundary on contest.

1f0681e

Offset current slot to set upper bound for close transaction

2c643f9

Comment on why we can throw exception when converting slotNo

2fd97ad

Increase timeout on flaky test

d6cdbcc

We should probably drop this test anyway

Replace 4-tuple with proper record for initialized state

4a3c826

Use distinct types to represent on-chain info at various stage in the SM

51b26d7

Keep contestationPeriod around in on-chain state both in contracts an…

e396f00

…d State

Replace closedAt with contestationDeadline

65dbd49

One mutation for close is still failing, on purpose

Generate faulty contestationPeriod to ensure checkClose works

4d722a3

Mutate Contest tx upper bound

926dc99

Use Plutus' DiffMilliSeconds as ContestationPeriod

2663acb

abailly added 2 commits May 19, 2022 09:28

Correctly compute contestation deadline in Close tx

4e3ce74

Check Contest tx is within contestation deadline bounds

312ac0f

ch1bo force-pushed the ensemble/192/contestation-period branch from d447fc2 to 312ac0f Compare May 19, 2022 07:28

ch1bo merged commit b73e2cb into master May 19, 2022

ch1bo deleted the ensemble/192/contestation-period branch May 19, 2022 09:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Account for contestation period in validators #351

Account for contestation period in validators #351

KtorZ commented May 12, 2022 •

edited by ghost

Loading

github-actions bot commented May 13, 2022 •

edited

Loading

github-actions bot commented May 13, 2022 •

edited

Loading

ch1bo May 19, 2022

ch1bo May 19, 2022

ch1bo May 19, 2022

ch1bo May 19, 2022

ch1bo May 19, 2022

ch1bo May 19, 2022

ch1bo May 19, 2022

ch1bo May 19, 2022

ch1bo May 19, 2022

ch1bo May 19, 2022

Account for contestation period in validators #351

Account for contestation period in validators #351

Conversation

KtorZ commented May 12, 2022 • edited by ghost Loading

github-actions bot commented May 13, 2022 • edited Loading

Transactions Costs

Cost of Init Transaction

Cost of Commit Transaction

Cost of CollectCom Transaction

Cost of Close Transaction

Cost of Abort Transaction

Cost of FanOut Transaction

github-actions bot commented May 13, 2022 • edited Loading

Unit Test Results

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KtorZ commented May 12, 2022 •

edited by ghost

Loading

github-actions bot commented May 13, 2022 •

edited

Loading

github-actions bot commented May 13, 2022 •

edited

Loading