Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower requirement for coverage percent in genericCoverTable #386

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

ch1bo
Copy link
Collaborator

@ch1bo ch1bo commented Jun 3, 2022

This results in a less strict execution of properties with many labels
and should be okay as we are only interested that ALL cases are covered,
but not necessarily with (close to) uniform distribution.

…able

This results in a less strict execution of properties with many labels
and should be okay as we are only interested that ALL cases are covered,
but not necessarily with (close to) uniform distribution.
@ch1bo ch1bo requested review from KtorZ and abailly-iohk June 3, 2022 06:56
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2022-06-03 07:07:05.090805591 UTC
Max. memory units 14000000.00
Max. CPU units 10000000000.00
Max. tx size (kB) 16384

Cost of Init Transaction

Parties Tx size % max Mem % max CPU
1 4738 25.92 15.06
2 4938 19.55 10.96
3 5137 18.87 10.34
5 5538 22.85 12.34
10 6536 49.17 27.37
30 10540 66.98 34.02
41 12739 91.35 46.58

Cost of Commit Transaction

Currently only one UTxO per commit allowed (this is about to change soon)

UTxO Tx size % max Mem % max CPU
1 5862 17.97 8.80

Cost of CollectCom Transaction

Parties Tx size % max Mem % max CPU
1 13865 21.10 11.45
2 14207 38.17 20.94
3 14875 64.07 35.46
4 15152 84.52 47.13

Cost of Close Transaction

Parties Tx size % max Mem % max CPU
1 9598 10.71 5.71
2 9656 10.56 5.60
3 9920 12.72 6.76
5 10172 14.85 7.88
10 11496 24.57 13.16
30 15245 55.37 29.67
57 16347 67.15 35.25

Cost of Contest Transaction

Parties Tx size % max Mem % max CPU
1 9337 7.72 4.09
2 9693 10.82 5.74
3 9922 12.44 6.62
5 10448 16.25 8.65
10 11601 28.60 15.31
30 15424 59.64 32.05
36 16326 63.53 34.10

Cost of Abort Transaction

Parties Tx size % max Mem % max CPU

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

UTxO Tx size % max Mem % max CPU
2 13383 12.31 7.13
3 13547 15.78 9.18
10 13783 24.59 14.18
60 15463 98.83 56.86

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Unit Test Results

225 tests  ±0   223 ✔️ ±0   7m 9s ⏱️ -40s
  83 suites ±0       2 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 1c0cbed. ± Comparison against base commit c1baddb.

Copy link
Collaborator

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I understand the motivation behind this PR (smaller test execution times?). But I am also not standing against 🤷

@ch1bo
Copy link
Collaborator Author

ch1bo commented Jun 3, 2022

also

The Abort mutations became quite length and did 800 executions because of the coverage. With this change we get
image

@ch1bo ch1bo merged commit 9acd79d into master Jun 3, 2022
@ch1bo ch1bo deleted the ch1bo/mutation-test-speed branch June 3, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants