add std flake and tullia #625
Conversation
default.nix
Outdated
| url = "https://github.com/input-output-hk/cardano-node"; | ||
| rev = "1.35.3"; | ||
| sha256 = "020fwimsm24yblr1fmnwx240wj8r3x715p89cpjgnnd8axwf32p0"; | ||
| ref = "purity"; |
There was a problem hiding this comment.
@dermetfan Do we need this purity branch? What's the rationale/consequence of not having this? We are asserting that we are using cardano-node 1.35.3 in other locations and this branch seems to be on the master branch of node.
There was a problem hiding this comment.
Changed it to point to a new purity-backport-1.35.4 branch.
There was a problem hiding this comment.
Thanks for helping us @dermetfan, but we need more context and maybe even some training materials for the team to adopt this.
default.nix
Outdated
| url = "https://github.com/input-output-hk/cardano-node"; | ||
| rev = "1.35.3"; | ||
| sha256 = "020fwimsm24yblr1fmnwx240wj8r3x715p89cpjgnnd8axwf32p0"; | ||
| ref = "purity"; |
There was a problem hiding this comment.
@dermetfan Do we need this purity branch? What's the rationale/consequence of not having this? We are asserting that we are using cardano-node 1.35.3 in other locations and this branch seems to be on the master branch of node.
| { | ||
| cell, | ||
| inputs, | ||
| }: { |
There was a problem hiding this comment.
Why is this in a separate cell than the pipelines.nix?
There was a problem hiding this comment.
This is the naming convention we currently use for std.
The automation cell contains scripts and tasks for local execution.
The cloud cell contains only things that run on some hosted platform (like cicero).
Tullia tasks are valid standalone as they can be run locally without cicero, so they belong in the automation cell.
Cicero actions can only be run on cicero (and ours happen to run tullia tasks), so they belong in the cloud cell.
| } | ||
| ) | ||
| { | ||
| hydraJobs = std.harvest self ["automation" "hydraJobs"]; |
There was a problem hiding this comment.
Do we need this? I think this PR should be about moving the Hydra-CI stuff to Cicero. So feel free to remove all the now legacy things (release.nix, this hydraJobs expression) and make things less indirected
There was a problem hiding this comment.
hydraJobs is a well-known output and does an ok job of specifying what to build. I don't really see a benefit of changing it just because we now use other software to build it. We can even be compatible with both cicero and hydra this way. (Also I have 16 other repos atm that need CI so this would not be a priority)
ch1bo
force-pushed
the
tullia
branch
4 times, most recently
from
10ab6bf
to
92aa78d
Compare
4661: fix pure nix evaluation r=dermetfan a=dermetfan There was access to `builtin.currentSystem` in the nix evaluation for nix-shell so pure evaluation was not possible. Needed by cardano-scaling/hydra#625. Co-authored-by: Robin Stumm <[email protected]>
dermetfan
force-pushed
the
tullia
branch
3 times, most recently
from
98c43ad
to
0cd803c
Compare
ch1bo
force-pushed
the
tullia
branch
3 times, most recently
from
431a5fd
to
47d2c4d
Compare
Also fix impurities in the nix evaluation of CI jobs.