Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Favorites #18

Open
cardoso opened this issue Jan 7, 2019 · 2 comments
Open

[NEW] Favorites #18

cardoso opened this issue Jan 7, 2019 · 2 comments
Labels
🎉 feature New feature or request hacktoberfest

Comments

@cardoso
Copy link
Owner

cardoso commented Jan 7, 2019

Allow user to favorite a movie (local persistence only)
@cardoso cardoso added the 🎉 feature New feature or request label Jan 7, 2019
@ftp27
Copy link
Contributor

ftp27 commented Oct 1, 2019

I wonder how to open the favourites list? By tabs or navigation bar buttons?
And where do you want to store it? UserDefaults can fit perfectly, no extra dependencies and CoreData stack. I don't think that a user can pick more than 50 films.

@cardoso
Copy link
Owner Author

cardoso commented Oct 2, 2019 •
edited
Loading

@ftp27 I think UserDefaults is OK.

Navigation bar button for now is better. Tabs in the future.

This is my suggestion (you can think of something better if you want!)

  • Star button (★) on right side of first screen to see list of favorites
  • Star button on right side of second screen to add favorite
    - ☆ : not favorite
    - ★ : favorite

Thanks for your help!

ftp27 added a commit to ftp27/ReduxMovieDB that referenced this issue Oct 6, 2019
@ftp27
resolved cardoso#18
b66cb71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎉 feature New feature or request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ftp27 @cardoso