Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start UI testing #16 #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Start UI testing #16 #36

wants to merge 1 commit into from

Conversation

ThaysPrado
Copy link

I started UI tests with two tests on listView and DetailsView.
hope it is useful

@codecov-io
Copy link

Codecov Report

Merging #36 into master will increase coverage by 17.43%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #36       +/-   ##
===========================================
+ Coverage   69.85%   87.29%   +17.43%     
===========================================
  Files          13       13               
  Lines         428      433        +5     
===========================================
+ Hits          299      378       +79     
+ Misses        129       55       -74
Impacted Files Coverage Δ
...xMovieDB/Controllers/MovieListViewController.swift 93.06% <100%> (+3.48%) ⬆️
...uxMovieDB/Extensions/UIImageView+MoviePoster.swift 96.72% <100%> (ø) ⬆️
ReduxMovieDB/Thunks.swift 60% <0%> (+1.81%) ⬆️
ReduxMovieDB/API/TMDB.swift 71.87% <0%> (+3.12%) ⬆️
ReduxMovieDB/Controllers/SplitViewController.swift 85.71% <0%> (+33.33%) ⬆️
...ovieDB/Controllers/MovieDetailViewController.swift 83.33% <0%> (+83.33%) ⬆️
ReduxMovieDB/Model/Movie+Differentiable.swift 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e812687...3255e76. Read the comment docs.

@cardoso
Copy link
Owner

cardoso commented Oct 7, 2019

Thanks @ThaysPrado . I'll review as soon as possible.

@cardoso
Copy link
Owner

cardoso commented Oct 15, 2019

Both tests are failing here @ThaysPrado 🤔

Did you follow some guide for the UI tests? I think there should be some asserts. Maybe you can use this tutorial as a reference for the implementation: https://www.raywenderlich.com/960290-ios-unit-testing-and-ui-testing-tutorial#toc-anchor-014

This is only for a start, so even one good UI test would get this merged 😃

Copy link
Owner

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested in comment above

@ThaysPrado
Copy link
Author

It was my first attempt with UI testing. I will see the tutorial you mentioned.

Even though it is strange, the tests worked with me, I will see this more closely.
I think losing something

@cardoso
Copy link
Owner

cardoso commented Oct 18, 2019

@ThaysPrado understood! Looking forward to the improvements. Thank you!

@squash-labs
Copy link

squash-labs bot commented Jan 17, 2023

Manage this branch in Squash

Test this branch here: https://master-680e9.squash.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants