Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add release build for x86_64h-apple-darwin #1234

Merged
merged 1 commit into from
Aug 2, 2023
Merged

CI: Add release build for x86_64h-apple-darwin #1234

merged 1 commit into from
Aug 2, 2023

Conversation

NobodyXu
Copy link
Member

@NobodyXu NobodyXu commented Jul 31, 2023 •
edited
Loading

Signed-off-by: Jiahao XU [email protected]

@NobodyXu NobodyXu force-pushed the ci/build-for-x86h branch 5 times, most recently from 8aa014e to 3dcdcbe Compare July 31, 2023 11:15
@NobodyXu

This comment was marked as outdated.

Sign in to view
@NobodyXu NobodyXu added the Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency) label Jul 31, 2023
@NobodyXu NobodyXu enabled auto-merge August 1, 2023 03:30
@NobodyXu
Copy link
Member Author

NobodyXu commented Aug 1, 2023

I've changed this PR to only use build-std on x86_64h-apple-darwin, enabling build-std seems to have caused aarch64-pc-windows-msvc to fail.

@NobodyXu NobodyXu force-pushed the ci/build-for-x86h branch 4 times, most recently from ec7ce5b to 85c1be7 Compare August 1, 2023 06:35
@NobodyXu

This comment was marked as outdated.

Sign in to view
@NobodyXu NobodyXu disabled auto-merge August 1, 2023 06:55
@NobodyXu NobodyXu marked this pull request as draft August 1, 2023 06:55
@NobodyXu

This comment was marked as outdated.

Sign in to view
@NobodyXu NobodyXu force-pushed the ci/build-for-x86h branch 2 times, most recently from 6c6bce6 to 4cc419b Compare August 2, 2023 01:50
@NobodyXu NobodyXu marked this pull request as ready for review August 2, 2023 01:50
@NobodyXu
Copy link
Member Author

NobodyXu commented Aug 2, 2023

I've also disabled use of cargo-auditable on x86_64h-apple-darwin due to link failure.

On the side note, this probably is ok given that it will be used in universal executable.

I've turned back on cargo-auditable on x86_64h-apple-darwin.

@NobodyXu NobodyXu changed the title CI: Add release build for x86h-apple-darwin CI: Add release build for x86_64h-apple-darwin Aug 2, 2023
@NobodyXu NobodyXu removed the Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency) label Aug 2, 2023
@NobodyXu NobodyXu enabled auto-merge August 2, 2023 01:53
@NobodyXu NobodyXu added this pull request to the merge queue Aug 2, 2023
Merged via the queue into main with commit 8756e39 Aug 2, 2023
26 checks passed
@NobodyXu NobodyXu deleted the ci/build-for-x86h branch August 2, 2023 02:54
@NobodyXu NobodyXu mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passcod passcod passcod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NobodyXu @passcod