CM_FormField_Location add setValueByRequest

[sweleck]

as discussed in https://github.com/cargomedia/fuboo/pull/1615#issuecomment-20433388

[sweleck]

@alexispeter please review. I don't see a chance how I can test it... do you have any suggestion?

[alexispeter]

You should be able to instantiate a new Request with the corresponsing headers to set the ip.

[njam]

2 small notes:

• Please pass the request, using global state is bad, and we want to do it as far on the "outside" as possible therefore
• getIp can return null
• If the level from getByIp is too "high" you can try getting a lower level from the location object

[sweleck]

@alexispeter please review and merge if ok.

[alexispeter]

retest this please

[alexispeter]

• setValueByRequest() should also try to get the right level when it's smaller than levelMin
• fix tests

[sweleck]

@alexispeter please review and merge if ok

[njam]

• Docu
• Request::getIp can return null (add test?)
• level is compared with > and <= - shouldn't it either both times include or not include the current level? (not sure)
• Tests: Instead of writing all this data to the database, would it be possible to use mocks? This would make it more maintainable.

[alexispeter]

• if ($requestLocation->getLevel() <= $this->_options['levelMin']) { should probably be if ($requestLocation->getLevel() < $this->_options['levelMin']) {
• please also test that it works correctly when the location level is not high enough (you only test the other case)
• test what happens if it couldn't find a location from the ip
• test what happens if it couldn't get the desired level of location

[sweleck]

@alexispeter @njam

please review

[alexispeter]

• tests/library/CM/FormField/LocationTest.php use $this->assertNull($foo); instead of $this->assertSame(null, $foo);. Plus, when using assertSame($foo, $bar); the first arg should be the expected value and the second arg the actual value.
• Put commits that belong together together. E.g. 452b718 and 3a4304c

[sweleck]

@alexispeter please review.

I don't see where I violated this:

assertSame($foo, $bar); the first arg should be the expected value and the second arg the actual value.

[alexispeter]

In e4fe53d, but it was changed in d45e683.

[sweleck]

Sorry for mixing up the commits. Everything else ok?

[alexispeter]

All good for me.

[sweleck]

@fauvel please merge and create a tag.

[fauvel]

Tagged 1.1.151