Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Codestral Infill templates for code completion in llama.cpp #667

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

pentatonick
Copy link
Contributor

Hi @carlrobertoh,

Thank you for sharing this awesome project!

Please accept my humble contributions to fix the Codestral model for code completion, for which I use locally in llama.cpp.

Thank you,
Nick

@carlrobertoh
Copy link
Owner

Thank you! I think we should update the llama.cpp submodule as well.

@carlrobertoh carlrobertoh merged commit f910576 into carlrobertoh:master Aug 20, 2024
2 checks passed
@pentatonick
Copy link
Contributor Author

Thanks for the merge

I think we should update the llama.cpp submodule as well.

It is not as simple as just updating the git submodule, as the llama.cpp fails to build with the latest commit on master. This will require troubleshooting and I should be able to tackle in the future unless someone else beats me to it.

@pentatonick pentatonick deleted the codestral-fix branch August 20, 2024 10:05
carlrobertoh pushed a commit that referenced this pull request Aug 20, 2024
* fix: Codestral template variables and [MIDDLE] token

* fix: Codestral references CODESTRAL fixed template
carlrobertoh pushed a commit that referenced this pull request Aug 20, 2024
* fix: Codestral template variables and [MIDDLE] token

* fix: Codestral references CODESTRAL fixed template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants