issue-183: Use tags instead of suites to separate tests #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-todorov
force-pushed
the
issues/183
branch
from
54d5429
to
c6abda9
Compare
|
Reported bugs were not introduced with this PR but simply reported here because tests are now executing. |
steve-todorov
force-pushed
the
issues/183
branch
from
b7a00d2
to
8b098ed
Compare
carlspring
reviewed
Jan 25, 2021
carlspring
reviewed
Jan 25, 2021
carlspring
reviewed
Jan 25, 2021
steve-todorov
force-pushed
the
issues/183
branch
4 times, most recently
from
d84ef26
to
d35f100
Compare
|
SonarCloud Quality Gate failed. |
|
The failing quality gate is related to decreased code coverage which seems to be because SonarQube is (for some unknown reason) ignoring the integration test reports. We should probably look into it as a follow-up. Other than that - this PR is ready. |
mslowiak
reviewed
Jan 26, 2021
...a/org/carlspring/cloud/storage/s3fs/fileSystemProvider/NewAsynchronousFileChannelTestIT.java
Show resolved
Hide resolved
mslowiak
reviewed
Jan 26, 2021
src/test/java/org/carlspring/cloud/storage/s3fs/fileSystemProvider/NewByteChannelIT.java
Show resolved
Hide resolved
7 tasks
|
Could you please create a follow-up task for this? Thanks! |
1 task
Follow up here: |
steve-todorov
force-pushed
the
issues/183
branch
from
d35f100
to
3b73308
Compare
carlspring
reviewed
Jan 27, 2021
carlspring
reviewed
Jan 27, 2021
carlspring
reviewed
Jan 27, 2021
src/test/java/org/carlspring/cloud/storage/s3fs/util/EnvironmentBuilder.java
Outdated
Show resolved
Hide resolved
carlspring
reviewed
Jan 27, 2021
src/test/java/org/carlspring/cloud/storage/s3fs/util/EnvironmentBuilder.java
Show resolved
Hide resolved
7 tasks
This allows to reduce build time for running integration tests in CIs (i.e. when the unit tests have already ran in a previous build job and can safely be skipped in the current one)
…minio and finally it-s3 This should reduce S3 costs while running tests because MinIO has S3 compatible API. If MinIO tests fail, it's highly likely the S3 ones will fail or succeed as well.
steve-todorov
force-pushed
the
issues/183
branch
2 times, most recently
from
9f8ac79
to
b314cf1
Compare
steve-todorov
force-pushed
the
issues/183
branch
from
b314cf1
to
8320d7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request closes #183.
It is important to note this pull request has introduced two new profiles -
it-s3andit-miniowhich are used to trigger tests tagged with@S3IntegrationTestand@MinioIntegrationTest.Acceptance Test
mvn clean install -Punit-tests,it-minio,it-s3still works.Questions
Does this pull request break backward compatibility?
Does this pull request require other pull requests to be merged first?
Does this require an update of the documentation?