Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed python-xdist development dependency due to it not being used #1223

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Oct 10, 2024

Description:

Related issue (if applicable): NixOS/34721

Thanks to the amazing team over on NixOS, they pointed out that while Apprise references the python-xdist package, it does not actually use it. There is confusion as those who choose to use it do not get the desired/expected test results.

Removing it from the Apprise library for consistency.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@caronc caronc changed the title Removed xdist as it is not used Removed python-xdist development dependency due to it not being used Oct 10, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.37%. Comparing base (19c0d8a) to head (4b385ea).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1223   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files         148      148           
  Lines       20675    20675           
  Branches     3679     3679           
=======================================
  Hits        20545    20545           
  Misses        121      121           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 09bcb4a into master Oct 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant