Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ng-packagr support #13

Open
caroso1222 opened this issue Apr 30, 2018 · 4 comments
Open

Add ng-packagr support #13

caroso1222 opened this issue Apr 30, 2018 · 4 comments

Comments

@caroso1222
Copy link
Owner

I wonder, should we move to an ng-packagr based build workflow? or at least give support for that? in giving support I propose at least scaffolding the appropriate files, dependencies and lines to package.json for ng-packagr to work out of the box.

I bring up this issue because of how widely adopted ng-packagr is - it might add value to the schematics.

What do you think @NetanelBasal @edgargonzalez525?

@NetanelBasal
Copy link
Contributor

As I wrote in my article, the real benefit of this library is that it exposes the build process, so people can hook up into it.

What is missing for this library compared to ng-packagr?

@NetanelBasal
Copy link
Contributor

Also, start from angular-cli version 6, there is built-in support for libraries. They are using ng-packagr.

@caroso1222
Copy link
Owner Author

caroso1222 commented Apr 30, 2018 via email

@NetanelBasal
Copy link
Contributor

You can add this features to the gulp workflow. There is no reason for this library to be deprecated. I can't see any benefit for ng g library than using this library, both are working great with the angular-cli.

I think you should add the requested features and that's it. The real drawback of ng-packgr is that you can't control the build. For example, we need a postcss plugin for our build and it can't be done with ng-packgr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants