-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ng-packagr support #13
Comments
As I wrote in my article, the real benefit of this library is that it exposes the build process, so people can hook up into it. What is missing for this library compared to ng-packagr? |
Also, start from angular-cli version 6, there is built-in support for libraries. They are using ng-packagr. |
Thanks for your input!
Yes, these schematics may eventually become deprecated as being replaced by
ng g library, which I think is ok.
I also like the way we expose the raw build workflow so that you can play
around with it. My motivations to think about ng-packagr (without nuking
the current gulp workflow) were:
1. The current gulp workflow doesn't correctly support publishing scoped
packages.
2. No support for secondary entrypoints (think @foo/bar/baz, @foo/bar/utils)
3. A handful of people asking me on DM "what's the difference between this
and ng-packagr? Why should I use this over ng-packagr?". My intentions are
not to shadow ng-packagr in any way, it's just that I see people asking for
that packager very frequently.
…On Sun, Apr 29, 2018 at 11:32 PM Netanel Basal ***@***.***> wrote:
Also, start from angular-cli version 6, there is built-in support for
libraries. They are using ng-packagr.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADhNgOvV_hRLFAuy4a7Qw-caklE2QZrhks5ttpPUgaJpZM4TsE9Z>
.
|
You can add this features to the gulp workflow. There is no reason for this library to be deprecated. I can't see any benefit for I think you should add the requested features and that's it. The real drawback of ng-packgr is that you can't control the build. For example, we need a postcss plugin for our build and it can't be done with ng-packgr. |
I wonder, should we move to an ng-packagr based build workflow? or at least give support for that? in giving support I propose at least scaffolding the appropriate files, dependencies and lines to package.json for ng-packagr to work out of the box.
I bring up this issue because of how widely adopted ng-packagr is - it might add value to the schematics.
What do you think @NetanelBasal @edgargonzalez525?
The text was updated successfully, but these errors were encountered: