Support indexRemove in KTypeVTypeHashMap,KTypeHashSet,KTypeWormSet. #24
Conversation
| @@ -735,6 +735,27 @@ public void indexInsert(int index, KType key) { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Removes a key. | |||
There was a problem hiding this comment.
I think it would be safer to say "removes a key index previously acquired from {{@@link #indexOf}}?
| assert index <= mask || | ||
| (index == mask + 1 && hasEmptyKey); | ||
|
|
||
| VType previousValue = Intrinsics.<VType> cast(values[index]); |
There was a problem hiding this comment.
this is perhaps being overly picky but previous value for the empty key could be just returned without accessing the array... on the other hand - maybe it's good that it doesn't cheat and returns what really was in that slot? Can't decide.
There was a problem hiding this comment.
I don't see how we can get the previous value without accessing the array. Could you explain me?
The remove() method gets the empty key's previous value from the array.
There was a problem hiding this comment.
Duh. I'm sorry, I don't think I was thinking clearly. The code is obviously correct.
| @@ -188,6 +188,20 @@ | |||
| */ | |||
| public void indexInsert(int index, KType key, VType value); | |||
|
|
|||
| /** | |||
| * Removes a key-value pair. | |||
There was a problem hiding this comment.
Same as above - removes a key-value pair at an index previously acquired from...
|
That test is called "testAgainstHashMap" - |
|
Would you mind adding a changes entry, Bruno? This way I can just do a click-merge via github - I'm away from the office and without all the resources. |
bruno-roustant
changed the title
|
Done. Thanks for the review Dawid. |
New API method KTypeVTypeMap.indexRemove() + implementation in KTypeVTypeHashMap and KTypeVTypeWormMap.
New public method indexRemove() in KTypeHashSet and KTypeWormSet.