Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 port of cartographer_ros (library & executables) #1557

Open
MichaelGrupp opened this issue Nov 11, 2020 · 6 comments
Open

ROS2 port of cartographer_ros (library & executables) #1557

MichaelGrupp opened this issue Nov 11, 2020 · 6 comments

Comments

@MichaelGrupp
Copy link
Contributor

MichaelGrupp commented Nov 11, 2020

Components

  • library (see cartographer_ros/CMakeLists.txt)
  • nodes & other executables (see cartographer_ros/cartographer_ros/CMakeLists.txt)
  • the package.xml (and other relevant files for compiling in CI) would need to be adapted too of course

The library cmake file uses a glob filter to get all .cc files. This could be changed for the period of porting, to allow porting only a subset of files at a time (in correct dependency order of course).

Regarding executables I would say the first goal should be to port node_main.cc, then offline_node_main.cc and then all the remaining tools. Files that don't build yet should be excluded from the build temporarily, by commenting out in the cmake file.

How to test locally with Docker

Can be done in addition to building with colcon in your personal workspace.
This is how we would test before merging, so it makes also sense to test it like this locally.

Once #1543 and #1542 are merged, you can activate the build of cartographer_ros in Dockerfile.foxy and in scripts/install_debs.sh (see TODO comments in these files). Then run

docker build . --file Dockerfile.foxy --tag cartographer_ros:foxy

to build your branch (dashing can be done the same way).


As written also in #1536, you can have a look also at the outdated old port on the ros2-dashing-1.0.0 branch.

@jediofgever
Copy link

Hey,
just wanted to know whether ros2 branch builds with foxy ?. Please let me know if anyone has tried. Thank you

@seasony-vp
Copy link

Hey,
just wanted to know whether ros2 branch builds with foxy ?. Please let me know if anyone has tried. Thank you

It seems that the install fails. I created an issue #1579.

@MichaelGrupp
Copy link
Contributor Author

@jediofgever Work in progress. Not yet ready to build.

@seasony-vp This is unrelated to this issue. You are referring to the old port made by OSRF, we plan to make a new one here.

@imstevenpmwyca
Copy link

Dear @MichaelGrupp

Work in progress. Not yet ready to build.

Do you have any updates regarding this?

@MichaelGrupp
Copy link
Contributor Author

I didn't have the time for continuing the WIP state recently. But I will update here once there's something new.

@doisyg
Copy link

doisyg commented May 5, 2021

PR for rolling/galactic here #1622
(should maybe target a new branch ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants