Set up an initial CI with colcon on ROS2 Dashing & Foxy. #1543
Conversation
Signed-off-by: Michael Grupp <[email protected]>
Signed-off-by: Michael Grupp <[email protected]>
These are stubs at the moment and only build cartographer, but can be easily extended. Signed-off-by: Michael Grupp <[email protected]>
Signed-off-by: Michael Grupp <[email protected]>
Signed-off-by: Michael Grupp <[email protected]>
Signed-off-by: Michael Grupp <[email protected]>
|
Build and test looks fine, see the Travis logs. I would like to merge this before doing further steps like #1542. @clalancette Maybe you can also have a look. I literally started working ROS2 this week out of interest ;) |
| cd catkin_ws/src | ||
| # Create a new workspace in 'dev_ws'. | ||
| mkdir -p dev_ws/src | ||
| cd dev_ws/src | ||
| wstool init |
There was a problem hiding this comment.
This is probably a good opportunity to switch from wstool -> vcstool, since wstool is indeed deprecated (and now unmaintained).
There was a problem hiding this comment.
I would do this this as a separate change because it also needs to be done in the ROS1 code. I made a todo issue: #1549
|
|
||
| FROM osrf/ros:dashing-desktop | ||
|
|
||
| ARG CARTOGRAPHER_VERSION=master |
There was a problem hiding this comment.
I'm not really familiar with how cartographer CI generally works, but shouldn't this be ros2-dashing? Same for Dockerfile.foxy below.
There was a problem hiding this comment.
This just means that we use master of the cartographer core library. The ROS part is the correct branch.
MichaelGrupp
requested review from
amaldo
and removed request for
wohe and
bochen87
This is a preparation for the ROS2 port.
It currently builds and tests only the cartographer library, which was
already made compatible with ROS2.
cartographer_ros, cartographer_ros_msgs and cartographer_rviz can
be activated in the Dockerfiles once they reach a state where they are
compatible with ROS2's build system.