Fixes segmentation fault for empty pointclouds #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See issue cartographer-project#1405 This small change fixes the issue where cartographer_rosbag_validate segfaults if the ros bag contains PointCloud2 messages without any points in them.
|
Hi, thank you for your contribution - may I ask you to sign off your commits? Please have a look here for how to fix it: https://github.com/cartographer-project/cartographer_ros/pull/1641/checks?check_run_id=2756820741 |
bochen87
reviewed
Sep 13, 2022
| *from = *to; | ||
| if (point_cloud.size() > 0) { | ||
| *from += cartographer::common::FromSeconds(point_cloud[0].time); | ||
| } |
There was a problem hiding this comment.
maybe print an error message to warn the user if the pointcloud size is 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1405
This small change fixes the issue where cartographer_rosbag_validate segfaults if the ros bag contains PointCloud2 messages without any points in them.