Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eigen alignment fix + copy prevention reference #1752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Eigen alignment fix + copy prevention reference #1752

wants to merge 1 commit into from

Conversation

twdragon
Copy link

  • Added Eigen alignment fix for Extrapolator allocation (useful on AVX systems). Sometimes Eigen structures can create a mess in linked object code (cartographer-project/#1909). This fixes one of the cases which leads Cartographer to crash during startup on some AVX systems.
  • Added copy prevention reference to the loop (clangd static analyzer)

@twdragon
Eigen alignment fix
b35eb1e 
	- Added Eigen alignment fix for Extrapolator allocation
	  (useful on AVX systems)
	- Added copy prevention reference to the loop
	  (clangd static analyzer)
	- Tested for performance (no deterioration)

Signed-off-by: Andrey Vukolov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twdragon