Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct vmware-tanzu/carvel-imgpkg module name instead of k14s #279

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

jpmcb
Copy link
Contributor

@jpmcb jpmcb commented Oct 15, 2021

This PR changes references of the k14s/imgpkg go module to be vmware-tanzu/carvel-imgpkg, primarily in the go.mod file. This is required to be able to run

go get github.com/vmware-tanzu/carvel-imgpkg

without errors

Ran ./hack/build-and-lint.sh to verify

Fixes #278

@jpmcb jpmcb temporarily deployed to TanzuNet Registry Dev e2e October 15, 2021 17:08 Inactive
@jpmcb jpmcb temporarily deployed to GCR e2e October 15, 2021 17:08 Inactive
@pivotaljohn
Copy link
Contributor

Thanks for chopping wood, here, @jpmcb.

Gonna mark this as "draft" only to avoid accidentally merging this before we're ready.

Please see comment on #278.

@pivotaljohn pivotaljohn marked this pull request as draft October 18, 2021 16:23
@DennisDenuto
Copy link
Contributor

DennisDenuto commented Oct 18, 2021

Thanks for the PR! 🚀 @jpmcb

In order to make this change consistent with other tools in the carvel suite, can you please create a docs/dev.md file with a section documenting the module rename. It is hopefully one way to help inform folk of this rename - if they run into issues.

For more details refer to the "documentation" section: https://github.com/vmware-tanzu/carvel/issues/153

@pivotaljohn
Copy link
Contributor

With those docs in place, we'd be good to just roll forward: pulling out of draft. 👍🏻

@pivotaljohn pivotaljohn marked this pull request as ready for review October 19, 2021 16:51
@DennisDenuto
Copy link
Contributor

@joaopapereira mentioned at standup he would prefer this PR go in a release without any other changes.

So, that is looking to be v0.22.0.

- Add documentation for devs switching to new module path

Signed-off-by: John McBride <[email protected]>
@jpmcb jpmcb temporarily deployed to GCR e2e October 20, 2021 16:56 Inactive
@jpmcb jpmcb temporarily deployed to TanzuNet Registry Dev e2e October 20, 2021 16:56 Inactive
@jpmcb
Copy link
Contributor Author

jpmcb commented Oct 20, 2021

@DennisDenuto - added a docs/dev.md - let me know if there are any other changes y'all want!

@DennisDenuto
Copy link
Contributor

Thanks @jpmcb docs/dev.md look great!!

We plan on having this PR merged/released for v0.22.0

@joaopapereira joaopapereira merged commit 1456d03 into carvel-dev:develop Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use go get to include imgpkg libraries
5 participants