-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to handle additional OCI tags from user input #553
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Joe Searcy <[email protected]>
Signed-off-by: Joe Searcy <[email protected]>
Signed-off-by: Joe Searcy <[email protected]>
Signed-off-by: Joe Searcy <[email protected]>
Signed-off-by: Joe Searcy <[email protected]>
Signed-off-by: Joe Searcy <[email protected]>
Signed-off-by: Joe Searcy <[email protected]>
Signed-off-by: Joe Searcy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks and a question.
Do you think it would also make sense to add 1 end 2 end test to ensure all is good?
Signed-off-by: Joe Searcy <[email protected]>
Signed-off-by: Joe Searcy <[email protected]>
Signed-off-by: Joe Searcy <[email protected]>
Signed-off-by: Joe Searcy <[email protected]>
I'm not familiar with the end-to-end tests. Can you point me at an example or describe what that might look like? |
Maybe we can use https://github.com/carvel-dev/imgpkg/blob/develop/test/e2e/push_test.go as a base. Just making sure that the correct tags are added to the file and also in the registry (https://github.com/carvel-dev/imgpkg/blob/develop/test/e2e/copy_from_lockfiles_test.go#L226), this last example is on how can we check that multiple tags are present in the registry but the rest of the test is a copy test which we do not want to do. |
Ok, I'll take a look and give it a shot |
I've not been able to look at this much in the past few months due to a job change, but will be getting back to it soon |
These changes add the ability to specify additional OCI tags to be pushed when using
imgpkg
.It adds the
--additional-tags
flag toimgpkg push
command and allows the user to specify a comma separated list of additional tags, or the flag can be reused multiple times. This flag functions for both images and bundles.Comma Separated List
Multiple flags
Fixes #355