Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update module name #927

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Update module name #927

merged 2 commits into from
Apr 16, 2024

Conversation

praveenrewar
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

@praveenrewar
Update module name
1dfead4 
Signed-off-by: Praveen Rewar <[email protected]>
@praveenrewar
Update missed copyright headers
29d4b40 
Signed-off-by: Praveen Rewar <[email protected]>
sethiyash
sethiyash approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@sethiyash sethiyash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@praveenrewar praveenrewar mentioned this pull request Apr 16, 2024
Closed
5 tasks
@100mik 100mik merged commit 8b5e6a3 into carvel-dev:develop Apr 16, 2024
5 checks passed
@praveenrewar praveenrewar deleted the module-name branch April 16, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethiyash sethiyash sethiyash approved these changes

@100mik 100mik 100mik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praveenrewar @sethiyash @100mik