Bug fix: decode TOML array of tables #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcheadle-vmware
commented
Apr 19, 2022
| @@ -74,7 +74,13 @@ func (c Conversion) fromUnorderedMaps(object interface{}) interface{} { | |||
| typedObj[i] = c.fromUnorderedMaps(item) | |||
| } | |||
| return typedObj | |||
|
|
|||
| case []map[string]interface{}: | |||
There was a problem hiding this comment.
Having the case map[interface{}]interface{}: earlier in this function makes me think that we should cover the similar case: []map[interface{}]interface{}:. However, I could not construct a TOML map with non 'string' map keys.
Ultimately, I was left with this question:
- "Why is the input of an array of maps not covered by the
[]interface{}case?"
There was a problem hiding this comment.
Another way to ask the question:
- "Why does
toml.decodereturn different types of slices rather than always returning[]interface{}"
Found others hitting up against the toml.Unmarshal inconsistencies: BurntSushi/toml#169
cppforlife
reviewed
Apr 20, 2022
pivotaljohn
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
LGTM.
In addition to @cppforlife's formatting nits, I'm suggesting a note to explain both where this specific type of slice is coming from and why we can't just combine all the cases... for now.
Thanks for tackling this one, @gcheadle-vmware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #630
added
case []map[string]interface{}:to conversion process.