Stub unavailable source when reporting Starlark errors #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivotaljohn
force-pushed
the
handle-unavail-source
branch
from
22d0016
to
673de27
Compare
cppforlife
reviewed
Jun 22, 2022
- record the fact that we intend for this to be a temporary fallback strategy: that we still aspire to supply offending lines of source even if not part of the Library under evaluation.
pivotaljohn
commented
Jun 24, 2022
| // - a function from another Library | ||
| // - Starlark sourced from within ytt (e.g. out-of-the-box validation functions) | ||
| sc = e.loader.FindCompiledTemplate(pos.Filename()) | ||
| if reflect.ValueOf(sc).IsNil() { |
There was a problem hiding this comment.
required idiom as sc is an interface, not a pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: