synched actual website js with ytt embedded website js #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's some corresponding CSS that prolly also drifted (there are minor visual defects with the current state of the PR)... Either way seems reasonable:
|
|
Not quite there. At this point, I'd recommend dropping back to the 4-line patch that's a pure improvement. Not sure what the
|
|
closing in favor of #720 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #404
note i copied the app.js from carvel.dev into here and then tried to fix all the links to be relative again, but i'm keeping a few other changes that looked like just organic drift. Please do let me know if those should also be removed.