Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.40.x fix CVE #773

Merged
merged 6 commits into from
Dec 1, 2022
Merged

0.40.x fix CVE #773

merged 6 commits into from
Dec 1, 2022

Conversation

rohitagg2020
Copy link
Contributor

0.40.x fix CVE

@rohitagg2020
Fixing go cve's by bumping golang version
f9a7181 
Fixing go cve's by bumping golang version
@rohitagg2020
Updating go version in workflows.
ecd6187 
Updating go version in workflows.
@rohitagg2020 rohitagg2020 marked this pull request as ready for review November 30, 2022 17:29
pivotaljohn
pivotaljohn approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@pivotaljohn pivotaljohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

One question: the latest version of the golangci-lint is 1.50.1; I don't see an inherent problem with selecting an older version, but what's the driver behind that choice?

@rohitagg2020
Copy link
Contributor Author

I tried using 1.50.1 but was getting one error which is weird because the same is working on develop it seems. Hence falled back to this version.

@pivotaljohn pivotaljohn merged commit f64d2ae into v0.40.x Dec 1, 2022
@pivotaljohn pivotaljohn deleted the 0.40.x-fix-cve branch December 1, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pivotaljohn pivotaljohn pivotaljohn approved these changes

@joaopapereira joaopapereira Awaiting requested review from joaopapereira

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohitagg2020 @pivotaljohn @vmwclabot