fix for empty policy list #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty policy list causes error NameNotDefined 'p_sub' is not defined for expression ... because the token is represented by tuple in this string
hsluoyz
reviewed
Apr 15, 2019
| @@ -271,7 +271,7 @@ def enforce(self, *rvals): | |||
| for j, token in enumerate(self.model.model["r"]["r"].tokens): | |||
There was a problem hiding this comment.
I think this is reasonable. Maybe for j, token in enumerate(self.model.model["r"]["r"].tokens): should also be changed? What do you think @techoner ?
There was a problem hiding this comment.
I approved these changes he made.
leeqvip
approved these changes
Apr 16, 2019
TripleDogDare
added a commit
to TripleDogDare/pycasbin
that referenced
this pull request
Apr 23, 2019
Add tests related to casbin#10 Signed-off-by: Calvin Behling <[email protected]>
TripleDogDare
added a commit
to TripleDogDare/pycasbin
that referenced
this pull request
Apr 23, 2019
Add tests related to casbin#10 Signed-off-by: Calvin Behling <[email protected]>
TripleDogDare
added a commit
to TripleDogDare/pycasbin
that referenced
this pull request
Apr 23, 2019
Add tests related to casbin#10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty policy list causes error
NameNotDefined 'p_sub' is not defined for expression ...
because the token is represented by tuple in this string