feat: unmarshal data from response model #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
formatted with gofumpt
|
@seriouszyx @ComradeProgrammer @Resulte please review |
|
replaced #72 because of commit msg error |
wintbiit
changed the title
|
@WinterOfBit those two functions also need to be wrapped with Response. Fixed by: casdoor/casdoor@516f4b7 |
append GetUserCount & GetSortedUsers edition
@hsluoyz added |
hsluoyz
changed the title
|
🎉 This PR is included in version 0.26.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formatted with gofumpt
solved: #71
Need to mention that in casdoor
/api/get-sorted-usersand/api/get-user-countreponse are not replaced by responseOk. So in sdk I left them unchanged in my commit. Is this already enough orget-sorted-usersandget-user-countwill be changed later?