Prevent classes.default from being mutated #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Can you run |
rmarscher
force-pushed
the
immutable-default-classes
branch
from
9eecf9f
to
5e1a338
Compare
Introduced lodash/cloneDeep to make sure classes.default are not mutated inside mergeClasses().
rmarscher
force-pushed
the
immutable-default-classes
branch
from
5e1a338
to
32de4dc
Compare
|
Great! There was no |
|
Ah, I just made a PR/test to fix this and saw you did it already. Thanks for doing this! |
|
Perfect! This is up at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced lodash/cloneDeep to make sure classes.default are not mutated inside mergeClasses().