Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for caching #8

Merged
merged 1 commit into from
Dec 21, 2023
Merged

feat: add support for caching #8

merged 1 commit into from
Dec 21, 2023

Conversation

alecthomas
Copy link
Collaborator

  - uses: cashapp/activate-hermit@v1
    with:
      cache: true

This necessitated switching to a composite action, and I couldn't figure out a way to keep the existing JS action when using it. TBH I think the script approach is a bit cleaner anyway.

Also introduced a CI test for the action, and verified it with act.

```yaml
  - uses: cashapp/activate-hermit@v1
    with:
      cache: true
```

This necessitated switching to a composite action, and I couldn't figure
out a way to keep the existing JS action when using it. TBH I think the
script approach is a bit neater anyway.

Also introduced a CI test for the action, and verified it with `act`.
@alecthomas
Copy link
Collaborator Author

cc @wesbillman

@alecthomas alecthomas merged commit 7b79792 into main Dec 21, 2023
2 checks passed
@alecthomas alecthomas deleted the aat/optional-caching branch December 21, 2023 08:19
Copy link
Collaborator

@quad quad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely is cleaner! I used node before for historical reasons.

@quad quad mentioned this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants