fix: use major version EAP snapshot when building EAP #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LATEST-EAP-SNAPSHOT was set to the stable release, causing the EAP build to fail.
r3mariano
commented
Jul 27, 2023
| @@ -84,7 +85,6 @@ intellij { | |||
| "gradle", | |||
| "java", | |||
| "terminal", | |||
| // This version is in sync with the IJ Ultimate version, not the GoLand version. | |||
There was a problem hiding this comment.
No longer true - we get the plugin version from the marketplace page.
r3mariano
changed the title
chris-ryan-square
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LATEST-EAP-SNAPSHOT was set to the stable release, causing the EAP build to fail.LATEST-EAP-SNAPSHOT was set to a version incompatible with the currently-set snapshot version. Switching from LATEST to a major-version one will help catch this problem in the future, but we might have to reconsider upgrading major versions since the failure here is that 232.8* wasn't compatible with 232.7*.