Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Padding -> Margin. #867

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Rename Padding -> Margin. #867

merged 4 commits into from
Mar 22, 2023

Conversation

colinrtwhite
Copy link
Member

Also renames start/end -> left/right. Left/right fits better with the flexbox spec and we don't support right-to-left layouts.

Follow up from the conversation here: #855

@colinrtwhite colinrtwhite merged commit cb258fe into trunk Mar 22, 2023
@colinrtwhite colinrtwhite deleted the colin/rename_margin branch March 22, 2023 20:13
@veyndan
Copy link
Contributor

veyndan commented Mar 24, 2023

Also renames start/end -> left/right. Left/right fits better with the flexbox spec and we don't support right-to-left layouts.

Have you got a link to the spec? I'm kinda surprised because CSS logical properties are promoted pretty heavily (e.g., flex-start).

@colinrtwhite
Copy link
Member Author

@veyndan Margin isn't really part of the flexbox spec so it uses the default CSS left/right names for margin: https://www.w3schools.com/css/css_margin.asp

@veyndan
Copy link
Contributor

veyndan commented Mar 24, 2023

True, flex-start was a bad/wrong example. Margin's logical property counterparts to margin-left/margin-right are margin-inline-start/margin-inline-end. I'm just a bit concerned going with left/right as it's exclusionary of RTL (and vertical) writing modes.

@JakeWharton
Copy link
Collaborator

It does seem very weird to not use start/end in anything newly built.

@colinrtwhite
Copy link
Member Author

@veyndan That's a good point. I figured that using left/right was more in-line with web, but that seems incorrect. I'll revert back to start/end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants