Parse and generate deprecations from the schema #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow communicating deprecation through regular means.
swankjesse
reviewed
Apr 18, 2023
| return findAnnotation<Deprecated>() | ||
| ?.let { deprecated -> | ||
| require(deprecated.replaceWith.expression.isEmpty() && deprecated.replaceWith.imports.isEmpty()) { | ||
| "Schema deprecation does not support replacements: $this" |
swankjesse
approved these changes
Apr 18, 2023
colinrtwhite
approved these changes
Apr 18, 2023
colinrtwhite
added a commit
that referenced
this pull request
Apr 19, 2023
* trunk: Ensure children lambda type returns Unit (#932) Respect event type nullability (#931) Update kotlin monorepo to v1.8.20 (#889) No default for embedded Zipline code (#926) Annotate schema properties, not parameters (#924) Propagate network failures in Emoji Search (#927) Cancel HTTP call on coroutine cancellation in Emoji Search (#928) Remove empty lambda from jvm target declaration (#925) Add LazyListScope#itemsIndexed (#917) Parse and generate deprecations from the schema (#922) Add LazyListScope#items(Array<T>, …) and LazyListScope#itemsIndexed(Array<T>, …) (#918) Add LazyListScope#item (#916) Expose the host's safe area insets in HostConfiguration. (#913) Move LazyListScope to LazyDsl.kt (#915) Update jbCompose to v1.4.0 (#904) Update dependency com.vanniktech:gradle-maven-publish-plugin to v0.25.2 (#914) Update dependency com.android.tools.lint:lint to v31 (#911) Build treehouse-lazylayout-compose on all platforms (#909) Add instructions for building the Counter app for iOS/Android. (#906)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow communicating deprecation through regular means.