[core] Make AutoAWQ fused modules compatible with HF transformers
#244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing the breakage once again @younesbelkada. Do we need to add more testing into transformers to avoid these larger updates that break AutoAWQ? |
|
Thanks @casper-hansen , we do have tests in transformers to test this feature - https://github.com/huggingface/transformers/blob/main/tests/quantization/autoawq/test_awq.py#L231 this is how I was able to flag there was an issue with transformers main |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes current issues with transformers main (next release) and autoawq + fused modules. The caching mechanism has been refactored thus requiring some changes on AutoAWQ side to make things compatible.
Related PR: huggingface/transformers#26681
cc @casper-hansen