Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move gtag config from theme to preset options #1069

Merged
1 commit merged into from
Apr 14, 2023
Merged

Move gtag config from theme to preset options #1069

1 commit merged into from
Apr 14, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 14, 2023

What does this PR fix?

Invalid gtag config placement - build failing after #1068:

Error: Unable to build website for locale en.
Error: Error: The "gtag" field in themeConfig should now be specified as option for plugin-google-gtag. For preset-classic, simply move themeConfig.gtag to preset options. More information at facebook/docusaurus#5832.

Related task: #1067.

Checklist

  • Docs are successfully building - yarn install && yarn run build.
  • All technical procedures have been tested.

@ghost ghost requested a review from bradjohnl April 14, 2023 09:22
@ghost ghost requested a review from ACStone-MTS as a code owner April 14, 2023 09:22
@ghost ghost self-assigned this Apr 14, 2023
@ghost ghost merged commit 397622c into dev Apr 14, 2023
@ghost ghost deleted the fix-bc-gtag-config branch April 14, 2023 10:07
ghost pushed a commit that referenced this pull request Aug 21, 2023
Move gtag config from theme to preset options
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant