Upgrade project to .NET Standard 2.0 #5
Conversation
|
|
||
| Console.WriteLine(writer); | ||
|
|
||
| Assert.Throws<ParseErrorException>(() => velocityEngine.GetTemplate(GetFileName(null, "nv14", TemplateTest.TMPL_FILE_EXT))); |
There was a problem hiding this comment.
When converting to NUnit 3, I had to rewrite the test because of the removal of ExpectedException
The test actually fails with the expected exception when calling GetTemplate, so everything under that was never run. I just removed it since it didn't seem necessary.
| @@ -68,7 +68,7 @@ public struct TemplateTest | |||
|
|
|||
| static TemplateTest() | |||
| { | |||
| FILE_RESOURCE_LOADER_PATH = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, Path.Combine(ConfigurationManager.AppSettings["tests.src"], "templates")); | |||
| FILE_RESOURCE_LOADER_PATH = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "templates"); | |||
There was a problem hiding this comment.
This configuration was empty in the AppSettings so I just removed it instead of attempting to create new configurations.
| @@ -17,7 +17,6 @@ namespace NVelocity | |||
| using System; | |||
| using System.Collections; | |||
| using System.Data; | |||
| using System.Data.OleDb; | |||
There was a problem hiding this comment.
This was referenced and not used, unsure if .NET Core has an equiv but removing it didn't break the tests.
| project: NVelocity.sln | ||
| publish_nuget: false | ||
| build_script: | ||
| - dotnet build ./NVelocity.sln -c Release |
There was a problem hiding this comment.
I read through the Core project and it seemed a little bit overkill (for now) to pull everything into a separate build file, and I was having trouble running it on Ubuntu. So I just put it in here for now.
|
Nudge @jonorossi for feedback :) |
|
Looks great. Let's get this merged for now, but the build output is producing the file |
Upgraded the projects:
Also:
https://ci.appveyor.com/project/phillip-haydon/nvelocity/build/1.0.28