Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): more consistent bash results for plants and stone #4091

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

chaosvolt
Copy link
Member

Purpose of change

This consistency-checks and tweaks some bash and related yields from certain terrain innawoods to make some aspects a bit less annoying. In particular this also makes it a bit more reliable getting the basic trickle of limestone needed to start mining without already having access to mining (or using Mining Mod).

Describe the solution

  1. Set young trees and related (coca) to yield 1-4 long sticks instead of 0-5, allowing you to always get long sticks out of a tree in exchange for a lower max possible yield (in my experience you seem to encounter the annoyance of trees dropping no sticks way more often).
  2. Removed the 50% chance of getting nothing out of bashing underbrush and all related terrain that bash into withered plants outright. Cutting/digging grass for straw is already noticeably better as a way to get cordage en mass anyway so not vital to nerf I feel.
  3. Converted the yield of all misc mineral materials from mining rock walls from a bunch of tiny RNG rolls to a call to a new itemgroup, rock_mining_extra. Additionally took out the janky 0-1 hindrance to spawning rock salt and rhodonite, and changed range of zincite from 0-5 to 1-4.
  4. Set smoothed rock to have its potential bonus rock salt at just straight 10% chance instead of 10% chance to spawn 0-1 rock salt, and added a chance to spawn limestone (with amount scaled down based on its rock yield relative to solid rock).
  5. Gave strange temple rocks the same possible results given they seem to be more or less smoothed rock in all but their anomalous puzzle properties.
  6. Updated boulders so all types give limestone 80% of the time just as solid rock does, instead scaling min and max amounts based on how much lower their rock yield is. Additionally they can all call a result from rock_mining_extra, and that gets its chance to spawn scaled by how fewer rocks you get from the boulder. Medium boulders get the same amount of limestone as smoothed rock since same amount of basic rocks.
  7. Large boulders have had their standard rock yield scaled down to be about 80% that of solid rock walls, making it nice and consistent to have their limestone yield and chance of extra minerals likewise be 80% that of solid rock.

Describe alternatives you've considered

Adding a wider variety of ore items to boulder and solid rock results. Dunno which would really fit for random New England rock content so.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Did math :<
  3. Load-tested, smashed boulders, obtained limestone.

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 11, 2024
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it solves the issue of being unable to get limestone for bog iron since it allows it on small boulders.

@scarf005 scarf005 merged commit bf0fae4 into cataclysmbnteam:main Jan 12, 2024
9 checks passed
@chaosvolt chaosvolt deleted the bash-yield-updoots branch January 12, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants